Skip to content

WPF IME - Fixed last hangul letter being duplicated - #2973

Merged
amaitland merged 7 commits into
cefsharp:masterfrom
nyjin:master
Nov 25, 2019
Merged

amaitland merged 7 commits into
cefsharp:masterfrom
nyjin:master

Conversation

@nyjin

@nyjin nyjin commented Nov 16, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #1262

Summary:

  • Fixed an issue where the last letter was duplicated when if you press space bar key or any special key while entering Korean.

Changes:

  • Korean characters committed in the IME_ENDCOMPOSITION event are committed once more in the IME_COMPOSITION event.
    So I did not commit in IME_ENDCOMPOSITION event.

How Has This Been Tested?

  • Tested with sample project.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot

Copy link
Copy Markdown

✅ Build CefSharp 78.3.10-CI3358 completed (commit 357809a17c by @)

@amaitland amaitland changed the title fixed the problem that the last hangul letter is duplicated. WPF IME - Fixed last hangul letter being duplicated Nov 17, 2019
@amaitland

Copy link
Copy Markdown
Member

Please add a comment to your code that describes the reason for the branch as it may not be clear to someone viewing the source code at a later date.

@AppVeyorBot

Copy link
Copy Markdown

private void OnImeEndComposition(IntPtr hwnd)
{
owner.GetBrowserHost().ImeFinishComposingText(false);
if(languageCodeId != ImeNative.LANG_KOREAN)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a code comment here explaining the change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments have been updated.

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

Comment thread CefSharp3.sln.DotSettings Outdated
<s:Boolean x:Key="/Default/Environment/SearchAndNavigation/GotoSingleHierarchyItemImmediately/@EntryValue">False</s:Boolean>
<s:Boolean x:Key="/Default/Environment/SearchAndNavigation/GotoSingleUsageImmediately/@EntryValue">False</s:Boolean>
<s:Boolean x:Key="/Default/Environment/SearchAndNavigation/MergeOccurences/@EntryValue">True</s:Boolean>
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpKeepExistingMigration/@EntryIndexedValue">True</s:Boolean>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes to this file please.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Sorry to bother you.

handled = true;
break;
}
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert unnessicary formatting changes please

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Sorry to bother you.

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@amaitland
amaitland merged commit b804367 into cefsharp:master Nov 25, 2019
@amaitland amaitland added this to the 79.0.0 milestone Nov 25, 2019
kkwpsv pushed a commit to kkwpsv/CefSharp that referenced this pull request Dec 27, 2019
WPF IME - Fixed the problem that the last hangul letter is duplicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WPF - IME Windows 8.1/10/11

3 participants