Repository navigation
Deprecate cef.redist packages #93
Description
Activity
- changed the title
[-]Investigate depreciating cef.redist packages [/-][+]Investigate deprecating cef.redist packages [/+]on Feb 5, 2021 - added a commit that references this issue
on Jul 30, 2021 There was a problem with the net core package when using a runtime identifier, the locales/swiftshader files weren't being copied. Revert changes for now.
It doesn't look like moving the locales/swiftshader into the arch packages is possible for the net core packages. It may still be possible though not worth the effort.
Hi @amaitland,
after upgrading toCefSharp.Common.NETCore 93.1.70-CI4201(withchromiumembeddedframework.runtime 93.1.11), we face the issue that thelocalesandswiftshaderfolders are no longer copied when using a RuntimeIdentifier likewin-x64, and thus resources fail to load. Can the changes for this be reverted/fixed?Thanks!
@kpreisser Thanks for the reminder. The changes will need to be reverted as per my comment above.
Reacted by Konstantin PreißerIf you remove the packages from your cache and redownload them the problem should be resolved.
build https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40634148 using https://github.com/cefsharp/cef-binary/tree/cef/93
I've left
masterunchanged as I'll test replacing theruntime.jsonwith a.props/.targetsfile that adds thePackageReferenceentries based onRuntimeIdentifierIf that doesn't work then it's likely this idea won't work.
If you remove the packages from your cache and redownload them the problem should be resolved.
build https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40634148 using https://github.com/cefsharp/cef-binary/tree/cef/93
Thanks! Using these new packages seems to work.
It appears that
swiftshaderis being replaced and at some point in the future we can stop shipping theswiftshaderfolder as the new dlls are included in the base directory. This will simplify our packages slightly and potentially make deprecating cef.redist easier as we only have to deal with the locales, which are likely duplicated between the different archs currently (haven't confirmed this, will need to hash them all and confirm the files are the same across the three archs)Reference https://bitbucket.org/chromiumembedded/cef/issues/3176/win-linux-ship-vk_swiftshaderdll-vulkan
Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1060139 tracks removing of
Swiftshader.Once
Swiftshaderhas been removed movinglocalesinto a new package should be fairly trivial. I haven't checked though I suspect thatlocalesare the same for each archat least the windows ones, so we can possibly just ship a single set of files.If we only need to ship a single set of
localesthen it might be possible to use contentfiles to include the relevant files and programmatically setCefSettings.LocalesDirPath. Haven't done any testing around this yet.Removing of
SwiftShaderhas started https://bugs.chromium.org/p/chromium/issues/detail?id=1060139#c124Swiftshader has been removed in M102
https://bitbucket.org/chromiumembedded/cef/commits/916360e2e5805e90dd69d2b3a944e16fb929ac50
- changed the title
[-]Investigate deprecating cef.redist packages [/-][+]Deprecate cef.redist packages [/+]on Dec 27, 2023 - added 5 commits that reference this issue
on Jan 28, 2024 We've exceeded the quote limits on
MyGetso the oldcef.redistpackages will no longer be generated going forward.They newer
chromiumembeddedframework.runtimepackages will be used inCefSharp. Anyone using thecef.redistpacakges directly will need to migrate as well.cef.redist.x64 => chromiumembeddedframework.runtime.win-x64
cef.redist.x86 => chromiumembeddedframework.runtime.win-x86The packages have now been marked as deprecated on
Nuget.org.
chromiumembeddedframework.runtimearch specific packageschromiumembeddedframework.runtimearch specific packagesTarget is to make them compatible so we can deprecate the old Cef.redist packages.