Repository navigation
Deprecate cef.redist packages #93
Description
- Add extra copy of locales to
chromiumembeddedframework.runtimearch specific packages - Move Copy targets into
chromiumembeddedframework.runtimearch specific packages - chromiumembeddedframework.runtime package would need to add support for the build folder (currently only uses buildTransitive)
Target is to make them compatible so we can deprecate the old Cef.redist packages.
Metadata
Metadata
Assignees
Labels
No labels
Activity
[-]Investigate depreciating cef.redist packages [/-][+]Investigate deprecating cef.redist packages [/+]Nuget - chromiumembeddedframework.runtime add .props files to build f…
Nuget - Add CefRedist32/CefRedist64 props and extra copy Targets to c…
amaitland commentedon Jul 30, 2021
Commit 8a902f2 adds the required props.
Haven't tested to see if the folder structure for the swiftshader/locales directories is preserved.
Nuget - Add CefRedist32/CefRedist64 props and extra copy Targets to c…
amaitland commentedon Aug 11, 2021
There was a problem with the net core package when using a runtime identifier, the locales/swiftshader files weren't being copied. Revert changes for now.
amaitland commentedon Aug 11, 2021
It doesn't look like moving the locales/swiftshader into the arch packages is possible for the net core packages. It may still be possible though not worth the effort.
kpreisser commentedon Sep 3, 2021
Hi @amaitland,
after upgrading to
CefSharp.Common.NETCore 93.1.70-CI4201(withchromiumembeddedframework.runtime 93.1.11), we face the issue that thelocalesandswiftshaderfolders are no longer copied when using a RuntimeIdentifier likewin-x64, and thus resources fail to load. Can the changes for this be reverted/fixed?Thanks!
amaitland commentedon Sep 3, 2021
@kpreisser Thanks for the reminder. The changes will need to be reverted as per my comment above.
amaitland commentedon Sep 3, 2021
If you remove the packages from your cache and redownload them the problem should be resolved.
build https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40634148 using https://github.com/cefsharp/cef-binary/tree/cef/93
I've left
masterunchanged as I'll test replacing theruntime.jsonwith a.props/.targetsfile that adds thePackageReferenceentries based onRuntimeIdentifierReference https://github.com/cefsharp/CefSharp/blob/master/NuGet/PackageReference/CefSharp.Common.NETCore.targets#L142
If that doesn't work then it's likely this idea won't work.
kpreisser commentedon Sep 6, 2021
Thanks! Using these new packages seems to work.
amaitland commentedon Sep 12, 2021
It appears that
swiftshaderis being replaced and at some point in the future we can stop shipping theswiftshaderfolder as the new dlls are included in the base directory. This will simplify our packages slightly and potentially make deprecating cef.redist easier as we only have to deal with the locales, which are likely duplicated between the different archs currently (haven't confirmed this, will need to hash them all and confirm the files are the same across the three archs)Reference https://bitbucket.org/chromiumembedded/cef/issues/3176/win-linux-ship-vk_swiftshaderdll-vulkan
amaitland commentedon Feb 21, 2022
Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1060139 tracks removing of
Swiftshader.Once
Swiftshaderhas been removed movinglocalesinto a new package should be fairly trivial. I haven't checked though I suspect thatlocalesare the same for each archat least the windows ones, so we can possibly just ship a single set of files.If we only need to ship a single set of
localesthen it might be possible to use contentfiles to include the relevant files and programmatically setCefSettings.LocalesDirPath. Haven't done any testing around this yet.amaitland commentedon Apr 13, 2022
Removing of
SwiftShaderhas started https://bugs.chromium.org/p/chromium/issues/detail?id=1060139#c124amaitland commentedon Apr 27, 2022
Swiftshader has been removed in M102
https://bitbucket.org/chromiumembedded/cef/commits/916360e2e5805e90dd69d2b3a944e16fb929ac50
[-]Investigate deprecating cef.redist packages [/-][+]Deprecate cef.redist packages [/+]Remove cef.redist packages
Remove cef.redist packages (#110)
Create new chromiumembeddedframework.runtime.resources package
Include locales in chromiumembeddedframework.runtime.win packages
Re-add CefRedist32/CefRedist64 props
amaitland commentedon Feb 4, 2024
We've exceeded the quote limits on
MyGetso the oldcef.redistpackages will no longer be generated going forward.They newer
chromiumembeddedframework.runtimepackages will be used inCefSharp. Anyone using thecef.redistpacakges directly will need to migrate as well.amaitland commentedon Mar 1, 2024
cef.redist.x64 => chromiumembeddedframework.runtime.win-x64
cef.redist.x86 => chromiumembeddedframework.runtime.win-x86
amaitland commentedon Mar 23, 2024
The packages have now been marked as deprecated on
Nuget.org.