util: disable informers on secrets by black-dragon74 · Pull Request #5984 · ceph/ceph-csi

black-dragon74 · 2026-01-28T07:46:06Z

Describe what this PR does

This patch disables the secret cache which relied on Informers. As the informer was cluster scoped, it led to huge memory spikes due to decoding every secret.

The cache is disabled for it to be implemented in a better manner or to be removed entirely later.

This patch disables the secret cache which relied on Informers. As the informer was cluster scoped, it led to huge memory spikes due to decoding every secret. The cache is disabled for it to be implemented in a better manner or to be removed entirely later. Signed-off-by: Niraj Yadav <[email protected]>

Rakshith-R

Thanks

iPraveenParihar · 2026-01-28T09:04:50Z

@Mergifyio rebase

mergify · 2026-01-28T09:05:04Z

rebase

☑️ Nothing to do, the required conditions are not met

Details

any of:
- #commits-behind > 0 [📌 rebase requirement]
- -linear-history [📌 rebase requirement]
-closed [📌 rebase requirement]
-conflict [📌 rebase requirement]
queue-position = -1 [📌 rebase requirement]

iPraveenParihar · 2026-01-28T09:06:23Z

@Mergifyio queue

mergify · 2026-01-28T09:06:41Z

queue

❌ The pull request has been removed from the queue `default`

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify · 2026-01-28T09:06:42Z

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at cdbe6cb

This pull request spent 34 minutes 37 seconds in the queue, including 34 minutes 26 seconds running CI.
The checks were run on draft #5987.

Required conditions to merge

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

❌ multi-arch-build

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

nixpanic · 2026-01-28T10:57:10Z

@black-dragon74 , has it been confirmed that this addressees rook/rook#16962 ?

Please create an issue for re-enabling the informers. There is no need to keep the old function available, it is all in the git history.

black-dragon74 · 2026-01-28T11:33:28Z

@black-dragon74 , has it been confirmed that this addressees rook/rook#16962 ?

Yes. It will. There was no leak but rather too much allocation by the secret watcher.

Please create an issue for re-enabling the informers. There is no need to keep the old function available, it is all in the git history.

Done at: #5985, let’s keep the function for now as the majority of it will be reused, soon.

black-dragon74 · 2026-01-29T07:42:26Z

@Mergifyio requeue

mergify · 2026-01-29T07:42:32Z

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request.

mergify · 2026-01-29T07:42:34Z

queue

❌ The pull request has been removed from the queue `default`

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify · 2026-01-29T07:42:35Z

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at cdbe6cb

This pull request spent 2 hours 48 minutes 5 seconds in the queue, including 2 hours 47 minutes 55 seconds running CI.
The checks were run on draft #5991.

Required conditions to merge

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

❌ ci/centos/mini-e2e/k8s-1.33

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

black-dragon74 · 2026-01-29T10:44:25Z

/test ci/centos/mini-e2e/k8s-1.33

black-dragon74 · 2026-01-29T14:01:52Z

@Mergifyio requeue

mergify · 2026-01-29T14:02:13Z

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request.

mergify · 2026-01-29T14:02:14Z

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at fb4fb8f

mergify · 2026-01-29T14:02:15Z

black-dragon74 force-pushed the disable-secret-cache branch from 8a70211 to cdbe6cb Compare January 28, 2026 07:51

black-dragon74 mentioned this pull request Jan 28, 2026

csi-cephfsplugin container (inside the provisioner (or ctrlplugin pods)) high memory usage (and/or low default limits) rook/rook#16962

Closed

Rakshith-R added backport-to-release-v3.16 bug Something isn't working labels Jan 28, 2026

Rakshith-R approved these changes Jan 28, 2026

View reviewed changes

Comment thread internal/util/k8s/secrets.go

black-dragon74 mentioned this pull request Jan 28, 2026

Implement secret cache in a memory friendly manner #5985

Open

Madhu-1 approved these changes Jan 28, 2026

View reviewed changes

mergify Bot added the queued label Jan 28, 2026

mergify Bot added a commit that referenced this pull request Jan 28, 2026

Merge of #5984

da64937

mergify Bot mentioned this pull request Jan 28, 2026

merge queue: embarking devel (8b9bc61) and #5984 together #5987

Closed

29 of 78 tasks

mergify Bot added dequeued and removed queued labels Jan 28, 2026

mergify Bot added the queued label Jan 29, 2026

mergify Bot added a commit that referenced this pull request Jan 29, 2026

Merge of #5984

deec8ea

mergify Bot mentioned this pull request Jan 29, 2026

merge queue: embarking devel (8b9bc61) and #5984 together #5991

Closed

49 of 78 tasks

mergify Bot added dequeued and removed dequeued queued labels Jan 29, 2026

mergify Bot added the queued label Jan 29, 2026

mergify Bot added a commit that referenced this pull request Jan 29, 2026

Merge of #5984

e567241

mergify Bot mentioned this pull request Jan 29, 2026

merge queue: embarking devel (8b9bc61) and #5984 together #5995

Closed

62 of 78 tasks

mergify Bot removed the dequeued label Jan 29, 2026

mergify Bot merged commit fb4fb8f into ceph:devel Jan 29, 2026
36 checks passed

mergify Bot removed the queued label Jan 29, 2026

mergify Bot mentioned this pull request Jan 29, 2026

util: disable informers on secrets (backport #5984) #5998

Merged

Conversation

black-dragon74 commented Jan 28, 2026

Describe what this PR does

Uh oh!

Rakshith-R left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iPraveenParihar commented Jan 28, 2026

Uh oh!

mergify Bot commented Jan 28, 2026

☑️ Nothing to do, the required conditions are not met

Uh oh!

iPraveenParihar commented Jan 28, 2026

Uh oh!

mergify Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ The pull request has been removed from the queue default

Uh oh!

mergify Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

nixpanic commented Jan 28, 2026

Uh oh!

black-dragon74 commented Jan 28, 2026

Uh oh!

black-dragon74 commented Jan 29, 2026

Uh oh!

mergify Bot commented Jan 29, 2026

✅ This pull request will be re-embarked automatically

Uh oh!

mergify Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ The pull request has been removed from the queue default

Uh oh!

mergify Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

black-dragon74 commented Jan 29, 2026

Uh oh!

black-dragon74 commented Jan 29, 2026

Uh oh!

mergify Bot commented Jan 29, 2026

✅ This pull request will be re-embarked automatically

Uh oh!

mergify Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ The pull request has been merged automatically

Uh oh!

mergify Bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mergify Bot commented Jan 28, 2026 •

edited

Loading

❌ The pull request has been removed from the queue `default`

mergify Bot commented Jan 28, 2026 •

edited

Loading

mergify Bot commented Jan 29, 2026 •

edited

Loading

❌ The pull request has been removed from the queue `default`

mergify Bot commented Jan 29, 2026 •

edited

Loading

mergify Bot commented Jan 29, 2026 •

edited

Loading

mergify Bot commented Jan 29, 2026 •

edited

Loading