Repository navigation
build: rebase cephcsi container image to Rocky Linux 10 - #6413
Conversation
|
|
||
| # Ceph version to use | ||
| BASE_IMAGE=quay.io/ceph/ceph:v20 | ||
| BASE_IMAGE=docker.io/rockylinux/rockylinux:10 |
There was a problem hiding this comment.
Why not docker.io/rockylinux/rockylinux:10-minimal here too?
There was a problem hiding this comment.
As I thought the builder is kind of throwaway and the minimal image and we would need to install all the build tools with RUN.
There was a problem hiding this comment.
Right, it is easier for the builder image to be more complete so that installing additional tools is simpler.
There was a problem hiding this comment.
@nixpanic, you would need to add this image to ci/centos. a75413c
docker.io/rockylinux/rockylinux:10 quay.io/docker.io/rockylinux/rockylinux:10'
Trying to pull registry-ceph-csi.apps.ocp.cloud.ci.centos.org/docker.io/rockylinux/rockylinux:10...
Error: unable to copy from source docker://registry-ceph-csi.apps.ocp.cloud.ci.centos.org/docker.io/rockylinux/rockylinux:10: initializing source docker://registry-ceph-csi.apps.ocp.cloud.ci.centos.org/docker.io/rockylinux/rockylinux:10: reading manifest 10 in registry-ceph-csi.apps.ocp.cloud.ci.centos.org/docker.io/rockylinux/rockylinux: manifest unknown
script returned exit code 125
There was a problem hiding this comment.
Included the rockylinux:10 image with #6428 now too.
|
You also need to update |
nixpanic
left a comment
There was a problem hiding this comment.
I think this is pretty complete now , thanks!
|
|
||
| # Ceph version to use | ||
| BASE_IMAGE=quay.io/ceph/ceph:v20 | ||
| BASE_IMAGE=docker.io/rockylinux/rockylinux:10 |
There was a problem hiding this comment.
Right, it is easier for the builder image to be more complete so that installing additional tools is simpler.
|
/test ci/centos/mini-e2e/k8s-1.37 |
2 similar comments
|
/test ci/centos/mini-e2e/k8s-1.37 |
|
/test ci/centos/mini-e2e/k8s-1.37 |
Pulling the images and building this PR works fine. CI job If everything is included in the container-image, the e2e job is expected to pass as well. |
| ARG GO_ARCH | ||
| ARG BASE_IMAGE | ||
| ARG FINAL_BASE_IMAGE="quay.io/centos/centos:stream9-minimal" | ||
| ARG FINAL_BASE_IMAGE="docker.io/rockylinux/rockylinux:10-minimal" |
There was a problem hiding this comment.
dont we get in to pull limit problem for using this from docker.io? can we use https://quay.io/repository/rockylinux/rockylinux?tab=tags&tag=latest?
There was a problem hiding this comment.
yeah, uUsing quay.io would be nicer. We mirror the images in the CI repository already, so the limits from Docker Hub should not affect us (maybe with GitHub actions, but I don't remember we ever hit them there?).
|
/test ci/centos/mini-e2e/k8s-1.37 |
|
/test ci/centos/mini-e2e/k8s-1.37 |
|
/queue |
|
@Mergifyio rebase |
🛑 The pull request rule doesn't match anymoreDetailsThis action has been cancelled. |
The cephcsi image still built on CentOS Stream 9 packages while upstream Ceph has moved to Rocky Linux 10. This change moves the builder and final stage to Rocky Linux 10, install Tentacle client RPMs from the el10 ceph-release repo, and enable CRB repo. This drops the el9 ceph:v20 builder base and the stream9-minimal final image in favour of rockylinux:10 and rockylinux:10-minimal. Fixes ceph#6411 Signed-off-by: Shatadru Bandyopadhyay <[email protected]>
Apply the same el10 ceph-release and CRB repository changes to the CI devel container image used by containerized-test jobs. Signed-off-by: Shatadru Bandyopadhyay <[email protected]>
Signed-off-by: Shatadru Bandyopadhyay <[email protected]>
35a5109 to
31b3632
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.36 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.36 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/mini-e2e/k8s-1.36 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
|
Deprecation notice: This pull request comes from a fork and was queued with |
Merge Queue Status
This pull request spent 15 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
|
This changes the CPU requirements. x86-64-v3 is now required. |
The cephcsi image still built on CentOS Stream 9 packages while upstream Ceph has moved to Rocky Linux 10.
This change moves the builder and final stage to Rocky Linux 10, install Tentacle client RPMs from the el10 ceph-release repo, and enable CRB repo.
This drops the el9 ceph:v20 builder base and the stream9-minimal final image in favour of rockylinux:10 and rockylinux:10-minimal.
Fixes #6411
Describe what this PR does
Provide some context for the reviewer
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)