Publish in custom artifactory

After spending lot of time, I looked into the code & found that, the regex pattern is always matching for only registries pointing to npm. In my case we have a custom artifactory the URL that looks like //art01.spotifycloud.io

action/src/index.ts

Lines 62 to 64 in 31ff97e

    
           const authLine = userNpmrcContent.split("\n").find((line) => { 
        
             // check based on https://github.com/npm/cli/blob/8f8f71e4dd5ee66b3b17888faad5a7bf6c657eed/test/lib/adduser.js#L103-L105 
        
             return /^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(line);

Suggested solution

we can generalized the Regex and avoid hardcoding

const authLine = userNpmrcContent.split("\n").find((line) => {
  // Dynamically adapt to any registry by looking for :_authToken= pattern
  return /^\s*\/\/.*\/:[_-]authToken=/i.test(line);
});

fix: changesets#424 - Publish in custom artifactory

fix Publish in custom artifactory changesets#424

Shouldn't it just work if you create .npmrc with a content like this?

//art01.spotifycloud.io/:_authToken=YOUR_TOKEN

I don't understand when the logic falls apart right now.

@Andarist

@Andarist , I already had created my .npmrc as you suggested, but the catch here I forgot to highlight is, I am using a Auth _auth variable & not _authToken & I think that is also one of the reason's the code is going into the else.. condition

I have updated my PR for this fix as well, thanks for the input 👍

fix: Publish in custom artifactory changesets#424 with `auth` or `aut…

Navigation Menu

Repository navigation

Publish in custom artifactory #424

Suggested solution

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const authLine = userNpmrcContent.split("\n").find((line) => {
	// check based on https://github.com/npm/cli/blob/8f8f71e4dd5ee66b3b17888faad5a7bf6c657eed/test/lib/adduser.js#L103-L105
	return /^\s*\/\/registry\.npmjs\.org\/:[_-]authToken=/i.test(line);

Publish in custom artifactory #424

Description

Suggested solution

Activity

Andarist commented on Nov 21, 2024

gethari commented on Nov 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions