Skip to content

Running github.com/cli/cli/v2/pkg/cmd/attestation/trustedroot tests leaves debris #10462

Description

@williammartin

Description

Running the trusted root tests leaves debris in the local working directories.

➜  go test -tags=integration ./pkg/cmd/attestation/trustedroot -count 1

ok      github.com/cli/cli/v2/pkg/cmd/attestation/trustedroot   0.337s

➜ ✗ git status
On branch 9897-gh-cache-delete-exit-code
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        pkg/cmd/attestation/verification/tuf-repo-cdn.sigstore.dev.json
        pkg/cmd/attestation/verification/tuf-repo.github.com.json

nothing added to commit but untracked files present (use "git add" to track)

Expected Output

The expected output for this work is:

  • These tests do not leave debris in the current directory, preferably by ensuring these files go to tmp and are cleaned up after run

Activity

  1. added
    tech-debtA chore that addresses technical debt
    gh-attestationrelated to the gh attestation command
    coreThis issue is not accepting PRs from outside contributors
    on Feb 18, 2025
  2. shariful18317 commented on Mar 7, 2025

    @shariful18317
  3. Solver-Team commented on Mar 7, 2025

    @Solver-Team

    I opened a PR for this at #10561. Please take a look when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    coreThis issue is not accepting PRs from outside contributorsgh-attestationrelated to the gh attestation commandtech-debtA chore that addresses technical debt

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions