Repository navigation
Fix test debris from trustedroot integration tests - #10561
Closed
Solver-Team wants to merge 2 commits into
Closed
Solver-Team wants to merge 2 commits into
Solver-Team wants to merge 2 commits into
Conversation
phillmv
requested changes
Mar 7, 2025
| // Set the cache path to the provided dir, or a directory owned by the CLI | ||
| opts.CachePath = tufMetadataDir.UnwrapOr(filepath.Join(config.CacheDir(), ".sigstore", "root")) | ||
| // During tests, use a temporary directory that will be cleaned up | ||
| if os.Getenv("GO_INTEGRATION_TEST") == "1" { |
Contributor
There was a problem hiding this comment.
This feels like the wrong way to do this. Is it not possible to set the CachePath via the opts instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trustedroot integration tests were leaving TUF repository cache files in the working directory. This PR fixes the issue by:
Fixes: #10462
Created with Solver