Skip to content

CLI changelog #111

Description

@tierninho

Describe the feature or problem you’d like to solve

Is there a need to display a changelog for CLI, potentially via the command line?

Proposed solution

Something like gh --changelog or similar so users can learn more about updates. It is helpful for me in case I need to go back and see when a feature was released or if I missed the marketing material.

Activity

  1. probablycorey commented on Dec 17, 2019

    @probablycorey
    Contributor

    I'm going to split this into three stages.

  2. tierninho commented on Dec 19, 2019

    @tierninho
    ContributorAuthor

    Any value or reason to make gh changelog an alternative cmd, like we did with gh version?

  3. probablycorey commented on Dec 20, 2019

    @probablycorey
    Contributor

    Based on what I've learned, I think using actions to do this is probably more complicated than it needs to be. See #189 for more details.

  4. removed their assignment
    on Dec 20, 2019
  5. self-assigned this
    on Jan 6, 2020
  6. probablycorey commented on Jan 6, 2020

    @probablycorey
    Contributor

    This is trickier than I thought. Here are some options and I'm not sure what the best way forward is.

    Use a changelog.txt file

    This is easy to edit, easy edit for people to find in the repo, and easy for scripts to manipulate. But because we compile to a binary it is hard to get that text into the app via gh changelog. I think the way to do this is to add an extra build step to our makefile and to .goreleaser.yml that will convert the changelog into a go file.

    Use a changelog.json file

    This is a lot like the changelog.txt but it makes writing scripts to update it a little easier.

    Use a changelog.go file

    This makes it very easy to display the changelog in gh changelog, but it is less readable by users, and it's harder to write scripts that will directly edit a go file. It is also harder to turn this go file into something we can post in the relase notes on https://github.com/github/homebrew-gh/releases/tag/v0.3.5.


    I feel like I've spent too much time thinking about this and there is a very simple solution that eludes me. But I can't figure it out.

  7. tierninho commented on Jan 6, 2020

    @tierninho
    ContributorAuthor

    Perhaps the easiest solution for now is:

    gh changelog = opens browser tab to the new marketing site > release notes page

  8. mislav commented on Jan 7, 2020

    @mislav
    Contributor

    As for generating the changelog to use in online release notes, I've spiked something really quick: #199

    Now, assuming that we've gotten the GitHub Releases changelog out of the way, the next step is "linking" those notes into the binary so that gh changelog can do something useful. Personally, I don't feel really strongly that we should have a command to display the changelog; perhaps we could simply link to release notes from the man page (gh help). If we really do want to have a special command for this, I second @tierninho's excellent idea that we could simply have it open a URL, rather than having to figure out how to embed release notes into the binary itself. That way, the definite source for a changelog is the GitHub Release itself (which can also be amended by hand post-release if we want to polish up the notes).

  9. vilmibm commented on Jan 7, 2020

    @vilmibm
    Contributor

    i agree with mislav's assessment re: not needing a changelog command. we have gh version which could include a link to a release with a changelog and also link from gh help.

  10. probablycorey commented on Jan 7, 2020

    @probablycorey
    Contributor

    Personally, I don't feel really strongly that we should have a command to display the changelog; perhaps we could simply link to release notes from the man page (gh help)

    I can get behind that too. Looking at gh help it is a little crowded. Having the release notes link with the version command makes sense to me since release notes and version are pretty linked. How do people feel about havint gh version output something like...

    gh version 0.3.5 (2020-01-06)
    Release Notes: https://github.com/github/homebrew-gh/releases/tag/v0.3.5
    
  11. tierninho commented on Jan 7, 2020

    @tierninho
    ContributorAuthor

    How do people feel about havint gh version output something like...

    👍 on the idea and in favor of dropping gh-changelog altogether we implement this

  12. added a commit that references this issue on Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions