completions for aliases #1128

Activity

1. vilmibm

   added

   aliases

   enhancementa request to improve CLIa request to improve CLI

   on Jun 8, 2020
2. vilmibm

   removed

   aliases

   on Sep 29, 2020
3. vilmibm

   added

   coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributors

   on Oct 7, 2020
4. rsteube commented on Nov 6, 2020

   

   rsteube

   on Nov 6, 2020

   Contributor

   More actions

   Go this working in my fork by simply adding the aliases as subcommands before the completion generation:
   https://github.com/rsteube/gh/blob/master/pkg/cmdutil/completion.go#L23

   func Aliases() (map[string]string, error) {
   	if config, err := config.ParseDefaultConfig(); err != nil {
   		return nil, errors.New("failed to parse DefaultConfig:" + err.Error())
   	} else {
   		if aliasCfg, err := config.Aliases(); err != nil {
   			return nil, errors.New("failed to load AliasCfg:" + err.Error())
   		} else {
   			aliases := make(map[string]string)
   			for key, value := range aliasCfg.All() {
   				aliases[key] = value
   			}
   			return aliases, nil
   		}
   	}
   }
   
   c.PreRun = func(cmd *cobra.Command, args []string) {
   			if aliases, err := action.Aliases(); err == nil {
   				for key, value := range aliases {
   					cmd.Root().AddCommand(&cobra.Command{Use: key, Short: value, Run: func(cmd *cobra.Command, args []string) {}})
   				}
   			}
   		}

   ❤️React with ❤️3Reacted by Mislav Marohnić, Alfonso Montero López and Shoichi Aizawa
5. hjdivad commented on Nov 12, 2020

   

   hjdivad

   on Nov 12, 2020

   More actions

   FWIW a very simple bash script to wrap the existing completion:

   #!/usr/bin/env bash
   
   _gh_completion_with_aliases() {
     # if gh call super and add extra
     # assumes gh completion has already been sourced
     __start_gh
     aliases=$(gh alias list | cut -d: -f 1)
     matching_aliases=$(compgen -W "$aliases" "${COMP_WORDS[1]}")
     COMPREPLY+=($matching_aliases)
   }
   
   complete -F _gh_completion_with_aliases gh

   ❤️React with ❤️3Reacted by Mislav Marohnić, Alfonso Montero López and Shoichi Aizawa
6. lbesnard commented on Jul 1, 2021

   

   lbesnard

   on Jul 1, 2021

   More actions

   @hjdivad

     aliases=$(gh alias list | cut -d: -f 1)

   this is only good if aliases are one liner. Something along these lines is working better (but not perfect)

   $(gh alias list | grep -o -e '^[a-z].*:' | cut -d : -f1)

   ❤️React with ❤️1Reacted by David J. Hamilton
7. mislav commented on Aug 12, 2021

   

   mislav

   on Aug 12, 2021

   Contributor

   More actions

   Fixed in #3870
8. mislav

   closed this as completedon Aug 12, 2021
9. tonglil commented on Nov 4, 2025

   

   tonglil

   on Nov 4, 2025

   More actions

   Was there a regression in this?
   I am not getting tab completions for any aliases.
10. BagToad commented on Nov 4, 2025

    

    BagToad

    on Nov 4, 2025

    Member

    More actions

    Was there a regression in this?
    I am not getting tab completions for any aliases.

    @tonglil please open a new issue, thank you!