Skip to content

Add confirmation steps to risky write commands #1330

Closed
#1706
Closed
Add confirmation steps to risky write commands#1330
#1706
Labels
enhancementa request to improve CLI

Description

@ampinsk
ampinsk
opened on Jul 6, 2020

Right now, we have a few commands that we should ask the user to confirm before proceeding when using in a terminal.

  • gh pr create (when creating fork)
  • gh repo create
  • gh pr merge
  • gh repo fork (?)

A first pass at design:

Screen Shot 2020-07-06 at 9 43 43 AM

Let me know if there are other commands that we should include here!

Activity

  1. vilmibm
    added
    enhancementa request to improve CLI
    on Jul 9, 2020

  2. vilmibm commented on Jul 9, 2020

    @vilmibm
    vilmibm
    on Jul 9, 2020
    Contributor

    thanks for opening this!

  3. ShubhankarKG commented on Jul 13, 2020

    @ShubhankarKG
    ShubhankarKG
    on Jul 13, 2020
    Contributor

    #1357 has a fix for gh repo create and gh pr merge. It'll be better if someone else can take up the other two commands, viz. gh pr create and gh repo fork

  4. AliabbasMerchant commented on Jul 13, 2020

    @AliabbasMerchant
    AliabbasMerchant
    on Jul 13, 2020
    Contributor

    Great! I will take up the other two.

  5. mislav
    closed this as completedin #1706on Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions