Repository navigation
Added confirmation steps for risky write commands - #1357
Closed
ShubhankarKG wants to merge 12 commits into
Closed
ShubhankarKG wants to merge 12 commits into
ShubhankarKG wants to merge 12 commits into
Conversation
ShubhankarKG
commented
Jul 12, 2020
| confirmRepoCreate := false | ||
| promptString := "" | ||
| if input.OwnerID == "" { | ||
| promptString = "This will create " + name + " in your personal account. Continue? " |
Contributor
Author
There was a problem hiding this comment.
I personally didn't like this fix but I couldn't figure out a way to get the ${userName}/${repoName} format. I'd be glad if someone has a way out here.
1. The Repo Create tests have passed now. Lesser tests fail. 2. I forgot to add a condition in pr create submissions that led to all pr merges with flags failing. Added conditions to fix that.
Contributor
|
Thank you for this! We're currently behind on reviewing community PRs but will get to them as bandwidth allows. |
Contributor
Author
|
Sure, no problem |
…survey.Multiline that caused the initial options to disappear on subsequent options. Reverted it back to input so all should be good.
Miu98
approved these changes
Jul 26, 2020
ampinsk
self-requested a review
July 27, 2020 20:20
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Since at the moment of writing, this PR has been far behind (:sweat_smile:) trunk, I'd like to close this one and open a fresh new PR addressing these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1396
Fixes #1270
Ref #1330
Ref #1360
Changes:-
--public,--private,--internalwhich need to be passed. Failure to do so invokes an interactive session.-ythat passes true for all Confirm statements3a.
repo createhas two confirm statements :- Confirm submit? and Create local directory. Both shall be true when passed.3b.
pr mergehas a single confirmation:- Submit? working on this one 😅gh repo createon passing no arguments shall open up the interactive session as noted.