You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re: “Login using the browser” prompt: I'm not sure if we give the user enough information to make a decision at this point; i.e. we don't present any alternatives to the user until they choose "no". Maybe it would be useful to present all possible options at once?
I think it's important for the user to understand that if they choose to not login using the browser, they need to already have an authentication token ready. They might expect that skipping the browser will prompt them for username+password on the command line (a la hub), but I would want us to somehow communicate that this mode of authentication is not available, even though it's frequently asked for.
Proposed flow:
? Choose your authentication method:
Log in using a web browser
> Paste an authentication token
Tip: you can generate a Personal Access Token here https://github.com/settings/tokens
The minimum required scopes are `repo` and `read:org`.
? Paste your authentication token: *************
Activity
ampinsk commentedon Jul 27, 2020
Designs
gh auth login
gh auth logout
gh auth status
gh auth refresh
@vilmibm let me know if you need more input on the flags language, I'm cool with you taking a pass at it and I can give feedback!
mislav commentedon Jul 28, 2020
Re: “Login using the browser” prompt: I'm not sure if we give the user enough information to make a decision at this point; i.e. we don't present any alternatives to the user until they choose "no". Maybe it would be useful to present all possible options at once?
I think it's important for the user to understand that if they choose to not login using the browser, they need to already have an authentication token ready. They might expect that skipping the browser will prompt them for username+password on the command line (a la hub), but I would want us to somehow communicate that this mode of authentication is not available, even though it's frequently asked for.
Proposed flow:
@ampinsk What do you think?
vilmibm commentedon Jul 28, 2020
@mislav the same thing occurred to me and I went with this copy yesterday, thoughts?
mislav commentedon Jul 28, 2020
That looks great!
Nit: I don't think we need to say "OAuth" since that's an implementation detail.
ampinsk commentedon Jul 28, 2020
Yes thank you both for bringing this up, this is so much clearer 🙇♀️
The copy @mislav proposed above made a little more sense to me at a glance. I also really like the tip! 🤩