Repository navigation
Prompt displays several times #418
Description
Describe the bug
When the cli prompts to select an option if I click down or up to select one, it repeats the output again and again.
$ gh --version
gh version 0.5.4 (2020-02-13)
https://github.com/cli/cli/releases/tag/v0.5.4Steps to reproduce the behavior
- Create a new PR with the cli
- Try to select between Open the preview in the Browser and Create the PR
- See multiple times the prompt
Expected vs actual behavior
The expected behavior is only one prompt and select the options in that prompt
Logs
Paste the activity from your command line. Redact if needed.
Activity
billygriffin commentedon Feb 13, 2020
😱 Whoa, this isn't something we've seen or are able to reproduce. Would you mind sharing how you installed
ghand what OS you're using, and maybe any additional information you think might be relevant for us to figure out what's going on here?pitakill commentedon Feb 13, 2020
Sure!
My system is:
Linux euler 5.5.3-arch1-1 #1 SMP PREEMPT Tue, 11 Feb 2020 15:35:41 +0000 x86_64 GNU/LinuxI've installed the command from the AUR https://aur.archlinux.org/packages/github-cli/
My go version is:
And maybe this issue in one of the dependencies has a similar output (but not the same): AlecAivazis/survey#101
tierninho commentedon Feb 13, 2020
@pitakill Thanks for reporting this. I was able to reproduce this on OSX and Linux.
v0.5.4.The root cause is the width of your terminal window. If it is under the width of the "What's next..." sentence, then this happens when you attempt to select an option.
Looks like the text is being cut-off when the window is too narrow, prompting the application to try and print it again -> loop.
AliabbasMerchant commentedon May 6, 2020
I could also reproduce this bug (using Konsole in Fedora KDE Plasma)
This is definitely a bug in the
surveydependency, as the same version and code runs properly on another terminal (the vscode in-built terminal)It doesn't look like an issue with the terminal width. Konsole was full screen when I was using it, but still this error occurred. (While the vscode terminal was of smaller width than it, and it worked there)
mislav commentedon Sep 16, 2020
I think this was solved by an upgrade to the Survey library that we're using. Please comment if you can still reproduce this issue in
trunk, or after the next release!marmorag commentedon Nov 9, 2020
Hi, this bug still affect my version
Do you have any clue or workaround on how to fix this ?
Thanks.
mislav commentedon Nov 10, 2020
@marmorag Hi, could you tell us more about your OS, terminal emulator, and viewport width inside the terminal?
Often, you can use this command to measure terminal width:
tput colsmarmorag commentedon Nov 10, 2020
I use
Ubuntu 18.04.5 LTSwithKonsole 17.12.3terminalSystem-Glitch commentedon Dec 16, 2020
This bug has been fixed in v2.2.5 of the
surveylibrary: AlecAivazis/survey#309refactor: Remove _remove_dangling_messages from SlidingWindowConversa…