gh pr create creates branch in *upstream* not *origin*

Describe the bug

gh pr create

creates a branch in upstream not origin.

Note: This happens even if I've already pushed the branch to origin. Can find no way of preventing this behavior.

Steps to reproduce the behavior

Create local branch
Commit to local branch
gh pr create

This was a most unpleasant surprise.

Expected vs actual behavior

Expected behavior:

Create branch in origin and pull PR from origin branch to upstream

Actual behavior:

Create branch in upstream and create PR from upstream branch to upstream

Logs

gh pr create

Duplicate of #392

I'm sorry for the most unpleasant suprise. We plan to improve the case when you have already pushed the branch yourself:

cli/command/pr_create.go

Lines 97 to 98 in 08811c1

    
           // TODO: respect existing upstream configuration of the current branch 
        
           if err := git.Push(headRemote.Name, fmt.Sprintf("HEAD:%s", headBranch)); err != nil {

Thank you for reporting!

feat: Add kwargs to session interfaces for future extensibility (cli#464

Navigation Menu

Repository navigation

gh pr create creates branch in upstream not origin #464

Describe the bug

Steps to reproduce the behavior

Expected vs actual behavior

Logs

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// TODO: respect existing upstream configuration of the current branch
	if err := git.Push(headRemote.Name, fmt.Sprintf("HEAD:%s", headBranch)); err != nil {

gh pr create creates branch in *upstream* not *origin* #464

Description

Describe the bug

Steps to reproduce the behavior

Expected vs actual behavior

Logs

Activity

edwarnicke commented on Feb 15, 2020

mislav commented on Feb 17, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

gh pr create creates branch in upstream not origin #464