gh release create wildcard '*' not working on windows #5099

Activity

1. jamesjohnmcguire

   added

   bugSomething isn't workingSomething isn't working

   on Jan 25, 2022
2. cliAutomation

   added

   needs-triageneeds to be reviewedneeds to be reviewed

   on Jan 25, 2022
3. mislav

   added

   priority-3Affects a small number of users or is largely cosmeticAffects a small number of users or is largely cosmetic

   help wantedContributions welcomeContributions welcome

   and removed

   needs-triageneeds to be reviewedneeds to be reviewed

   on Jan 25, 2022
4. mislav commented on Jan 25, 2022

   

   mislav

   on Jan 25, 2022

   Last edited by mislav

   Contributor

   More actions

   Thank you for reporting!

   Unlike other platforms, Windows does not auto-expand wildcards in its shells when passing arguments to commands. For example, even though PowerShell has support for wildcard expansion like ls ./dist/*.tgz, it does not automatically perform such expansion. You can work around it by using the following expression in powershell:

   > gh release create v1.2.3 (get-item .\dist\*.tgz)

   To make it easier for gh users (and to make the example code that you pointed out work on Windows), I propose that we additionally expand glob expressions in arguments to commands such as gist create, release create, and release upload. This should perhaps only be done on Windows, since users on other platforms might be surprised that globs are additionally expanded by the gh process in addition to their shell.

   👍React with 👍11Reacted by Gabriel Weyer, James John McGuire, arcsector, Abubakar Riaz, Hailin Wang, MareMare, Yevheniy Tymchishin, Alberto, Hypothalamus, Max Kagamine and 1 more
5. mislav

   added

   priority-2Affects more than a few users but doesn't prevent core functionsAffects more than a few users but doesn't prevent core functions

   and removed

   priority-3Affects a small number of users or is largely cosmeticAffects a small number of users or is largely cosmetic

   on Jan 25, 2022
6. jessehouwing commented on Feb 7, 2022

   

   jessehouwing

   on Feb 7, 2022

   Last edited by jessehouwing

   Contributor

   More actions

   The problem with parsing (dir *.*) is that it only works in PowerShell and that the expanded command becomes too long, causing execution to fail.

   ResourceUnavailable: D:\a\azure-pipelines-tasks-zips\azure-pipelines-tasks-zips\build.ps1:27
   Line |
     27 |      & gh release create $tag -t "$tag" --target main -n """" ((dir _d …
        |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        | Program 'gh.exe' failed to run: An error occurred trying to start process 'C:\Program Files
        | (x86)\GitHub CLI\gh.exe' with working directory
        | 'D:\a\azure-pipelines-tasks-zips\azure-pipelines-tasks-zips'. The filename or extension is too long.At
        | D:\a\azure-pipelines-tasks-zips\azure-pipelines-tasks-zips\build.ps1:27 char:5 +     & gh release
        | create $tag -t "$tag" --target main -n """" ((dir _d … +    
        | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
   

   Commands like git add *.zip work fine, because the tool expands the wildcard internally.
7. mislav commented on Mar 18, 2022

   

   mislav

   on Mar 18, 2022

   Contributor

   More actions

   Let's just follow git's lead and expand wildcards on all platforms then, not just Windows. PRs welcome!

   👍React with 👍1Reacted by Jesse Houwing
8. thp-stopsmops commented on Feb 15, 2023

   

   thp-stopsmops

   on Feb 15, 2023

   More actions

   Another workaround to use when using cmd and not PowerShell is described here (found via this superuser answer) and could be used like this (note that this will invoke the tool once for each filename, so it's strictly speaking not equivalent to gh release create v1.2.3 dist/*.tgz on *NIX shells if there are multiple matching files):

   for /R %i in (dist\*.tgz) DO gh release create v1.2.3 %i
   

   Of course, eventually replacing this with wildcard/glob expansion in gh would clean things up a lot.

   A quick search reveals AssetsFromArgs might be the place where this can be added (at least for upload and create), but my golang skills are insufficient (read: non-existent) to actually go (ha!) and implement this:

   cli/pkg/cmd/release/shared/upload.go

   Line 37 in 7caf7da

   func AssetsFromArgs(args []string) (assets []*AssetForUpload, err error) {
9. andyfeller

   added

   gh-releaserelating to the gh release commandrelating to the gh release command

   on Oct 2, 2023
10. awakecoding

    added 2 commits that reference this issue on Dec 20, 2023

    fix for cli/cli#5099

    35ebf1c

    fix for cli/cli#5099

    59f3c49
11. WeihanLi

    added a commit that references this issue on Apr 17, 2024

    ci: fix release action

    ...

    4290465
12. jtmcg commented on Feb 10, 2025

    

    jtmcg

    on Feb 10, 2025

    Contributor

    More actions

    Acceptance Criteria

    Given a call to gist create, release create, or release upload command
    when a wildcard is used in the <files>... field
    then that wildcard is expanded on all platforms by gh

    👍React with 👍2Reacted by James John McGuire and Azeem
13. jtmcg

    self-assigned this

    on Feb 13, 2025
14. jtmcg

    closed this as completedin #10413on Mar 12, 2025