Skip to content

show version changes when upgrading a single extension #6483

Description

@mntlty

Describe the feature or problem you’d like to solve

When upgrading all extensions the output shows the version change

$ gh extension upgrade --all                             
[ext-name]: upgraded from v1.1.0 to v1.2.0
...

When upgrading a single extension the output does not

$ gh extension upgrade ext-name
✓ Successfully upgraded extension ext-name

The difference appears to be that

if m.dryRunMode {
is only on the upgradeExtensions func

Proposed solution

Show the version change for a single extension upgrade as well

Activity

  1. added and removed on Oct 24, 2022
  2. mislav commented on Oct 24, 2022

    @mislav
    Contributor

    Agreed! Thanks for pointing it out.

  3. mntlty commented on Oct 25, 2022

    @mntlty
    ContributorAuthor

    @mislav while looking at the code (and being aware of scope creep), I was thinking it might make for a nice refactor to allow for a list of extensions to upgrade.

    Currently, only a specific one or --all is supported. I am proposing to change the command to be

    gh extension upgrade {<name> [<name>]... | --all} [flags]
    

    which I think will also streamline the code to always accept a list

  4. dojutsu-user commented on Oct 26, 2022

    @dojutsu-user
    Contributor

    I would like to work on the original issue. @mislav Can you please assign me the same.

    @mntlty Nice idea, I believe it's better to open a new issue to track the same.

  5. dojutsu-user commented on Oct 31, 2022

    @dojutsu-user
    Contributor

    @mislav Can you assign me this issue?

  6. mislav commented on Nov 3, 2022

    @mislav
    Contributor

    @mntlty That's a worthwhile feature, but I believe it should be implemented separately from your original proposal.

    @dojutsu-user You are welcome to send contributions based on an issue even if you are not assigned to an issue. We don't typically assign outside contributors.

  7. added a commit that references this issue on Nov 21, 2022
    ef2bde4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLIhelp wantedContributions welcome

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions