Repository navigation
Show version diff when updating a single extension - #6647
Merged
Merged
Conversation
cliAutomation
added
the
external
samcoe
reviewed
Dec 5, 2022
| fmt.Fprintf(io.Out, "%s %s upgraded extension %s\n", cs.SuccessIcon(), successStr, name) | ||
| } else { | ||
| } else if name == "" { | ||
| fmt.Fprintf(io.Out, "%s %s upgraded extensions\n", cs.SuccessIcon(), successStr) |
Contributor
There was a problem hiding this comment.
What about displaying this message even if the extension name is provided? We can use the text.Pluralize helper to make it extension or extensions.
samcoe
approved these changes
Dec 8, 2022
samcoe
left a comment
samcoe
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the contribution @despreston! I pushed a small commit that made the change I suggested the other day as well as removed the special case error handling for upToDateError since there are no longer any code paths that return it from manager.Upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the extension upgrade command to use
Manager.upgradeExtensionswhen updating all extensions and single extensions. With this approach, we get the versions included when updating a single extension.Fixes #6483