Skip to content

docs: recommend nix-shell and declarative config for Nix/NixOS - #14592

Merged
tidy-dev merged 1 commit into
cli:trunkfrom
reginaldalfret:docs/nix-installation-nix-shell
Oct 5, 2026
Merged

tidy-dev merged 1 commit into
cli:trunkfrom
reginaldalfret:docs/nix-installation-nix-shell

Conversation

@reginaldalfret

Copy link
Copy Markdown
Contributor

Description

Updates the Nix/NixOS installation documentation in docs/install_linux.md to recommend
ix-shell -p gh for ad-hoc / temporary usage, and points users toward declarative NixOS configuration instructions (e.g. pkgs.gh via NixOS or Home Manager) rather than encouraging
ix-env -iA nixos.gh which modifies local profiles.

Resolves #14045

@reginaldalfret
reginaldalfret requested a review from a team as a code owner October 4, 2026 08:05
@reginaldalfret
reginaldalfret requested review from tidy-dev and a balanced review from Copilot October 4, 2026 08:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added external pull request originating outside of the CLI core team needs-triage needs to be reviewed ready-for-review and removed needs-triage needs to be reviewed labels Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for your pull request! While it doesn't meet all of our standard requirements, it appears to be a small, focused contribution and has been routed to the team for review.

Note: We still encourage linking to an issue with the help wanted label when possible, as it helps us prioritize and track contributions.

@tidy-dev tidy-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks!

@tidy-dev
tidy-dev merged commit 17142e0 into cli:trunk Oct 5, 2026
13 checks passed
gold-silver-copper added a commit to gold-silver-copper/ghtui that referenced this pull request Oct 7, 2026
A pull request's diff ran from the merge base of its head and its base
branch's current tip. Merged with a merge commit, a PR's head is in its
base branch, so that merge base was the head itself and the diff was
empty: on cli/cli#14592, GitHub says one file changed and ghtui showed
none. For a merged or closed PR the diff now runs from the base the PR
had (GitHub's baseRefOid, fetched by SHA when it isn't in the clone),
as GitHub's own does; an open PR's is still from its branch's tip.

Found in an audit and confirmed against GitHub. A git test merges a PR
with a merge commit and by squashing, and checks its files are its own
(and that the branch's tip leaves none after a merge commit); a state
test checks which base each kind of PR's diff asks for.
gold-silver-copper added a commit to gold-silver-copper/ghtui that referenced this pull request Oct 7, 2026
An ignored suite, cargo test -p ghtui-api --test contract -- --ignored
contract, turns each assumption the bugs fixed here rested on into a
dated fact, on data that doesn't change, through ghtui's own client
where it can:
- a comparison lists its newest commits only without per_page; with it,
  its first page is the oldest (ratatui v0.26.0...v0.26.1);
- branches by TAG_COMMIT_DATE come back by name, backwards, in GitHub's
  order by name (which puts wm-x before wm/x, so not bytes');
- a branch's associated PRs include other repositories';
- a long PR's commits(last: 1) is its headRefOid, and its checks are
  its head's (rust-lang/rust#160692, 229 commits);
- a GraphQL search has no page past 1,000, whatever it counts;
- a commit search's dates carry offsets;
- a PR merged with a merge commit has its head behind its base branch,
  and its baseRefOid gives its diff (cli/cli#14592);
- comments, reviews and commits come oldest first, releases and tags
  newest first, and a run's jobs a page at a time by per_page and page.

They only read, and pass without checking anything when there's no
token. A nightly workflow runs them, and the link crawl, with a token
from the CONTRACT_TOKEN secret, and skips cleanly without one;
graphql_json is public for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team ready-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recommend nix-shell instead of nix-env for NixOS installation

3 participants