Skip to content

issue edit: avoid race conditions when editing assignees, reviewers - #4876

Closed
mislav wants to merge 3 commits into
trunkfrom
issue-edit-sets
Closed

issue edit: avoid race conditions when editing assignees, reviewers#4876
mislav wants to merge 3 commits into
trunkfrom
issue-edit-sets

Conversation

@mislav

@mislav mislav commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add or remove assignees from an issue or PR without having to replace the entire set. This avoids race conditions with concurrent edit operations.

Fixes #4844
Followup to #4861

TODO:

  • reviewers

@mislav
issue edit: avoid race conditions when editing assignees
72068d9 
Add or remove assignees from an issue or PR without having to replace
the entire set. This avoids race conditions with concurrent edit
operations.
@CPerezz

CPerezz commented Apr 5, 2022

Copy link
Copy Markdown

Hi @mislav
Will this PR enable also the capability of assigning GH organization teams as reviewers??

The plan was to use this together with the automatic assignation from teams feature of Github. But I'm not sure that even this PR will enable this capability.

Thanks!

@nuhkoca

nuhkoca commented May 9, 2022

Copy link
Copy Markdown

Hey @mislav when will this be merged exactly?

This was referenced Sep 12, 2022
Open
Open
@mislav mislav assigned samcoe and unassigned mislav Jun 7, 2023
@samcoe samcoe mentioned this pull request Jun 13, 2023
Open
4 of 16 tasks
@williammartin
williammartin requested review from williammartin and removed request for williammartin September 11, 2023 16:00
@williammartin

williammartin commented Sep 11, 2023

Copy link
Copy Markdown
Member

@mislav do you have any intention of ever moving this PR out of draft mode? If not, perhaps we should close it and mark the original issue help wanted. Alternatively, is there something someone else could do to take it over the line?

@samcoe

samcoe commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

I am going to close this PR out as I think it is too far out of date to be brought back up to speed. I think anyone picking up the original issue can definitely use this code as inspiration/starting point for their PR.

@samcoe samcoe closed this Oct 18, 2023
@samcoe
samcoe deleted the issue-edit-sets branch October 18, 2023 13:27
@wingleung wingleung mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@samcoe samcoe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gh pr edit --add-reviewer Don't acquire organizational teams if it's not necessary

5 participants

@mislav @CPerezz @nuhkoca @williammartin @samcoe