gh pr edit --add-reviewer Don't acquire organizational teams if it's not necessary

Describe the feature or problem you’d like to solve

In Github Action

$ gh pr edit --add-reviewer [login]
error fetching organization teams: Resource not accessible by integration

The Github Action TOKEN does not provide this permission
Don't acquire organizational teams if it's not necessary

Proposed solution

Better integration with Github Actions

Additional context

Thanks for reporting!

This one is tricky. I generally agree that it doesn't make sense for an --add-reviewer <user> operation to require reading org teams, but right now we preload all review requests for the PR, including teams. Then, we replace values based on the final product after applying all --add-reviewer and --remove-reviewer values:

cli/pkg/cmd/pr/edit/edit.go

Lines 231 to 239 in 7e7735d

    
           union := githubv4.Boolean(false) 
        
           reviewsRequestParams := githubv4.RequestReviewsInput{ 
        
           	PullRequestID: id, 
        
           	Union:         &union, 
        
           	UserIDs:       ghIds(userIds), 
        
           	TeamIDs:       ghIds(teamIds), 
        
           } 
        
           client := api.NewClientFromHTTP(httpClient) 
        
           return api.UpdatePullRequestReviews(client, repo, reviewsRequestParams)

To fix this, we would have to stop preloading all previous reviewers when only --add-reviewer was used and use the union: true parameter when adding new reviewers to preserve previous review requests that may exist. Fixing this would also fix a race condition similar to #4835

@mislav

@mislav Hi
I would like to know when this Bug will be fixed. the /cc of my gh-ci-bot that relies on gh this ability

@wzshiming

@wzshiming It's being worked on (see linked PR) and most likely fixed in the next release.

Understand thank you

@mislav

@mislav Any update?

No, I was a bit stuck on the query aspect of the PR that's linked to this issue, but I plan to get back to it and finish the fix so that this can ship with the next release.

@mislav

hi, @mislav any update?

[8.0] MOD-7932: Use Github App Token For Backporting (#5093)

Related to: #11360

Use gh pr edit for reviewers now that cli/cli#4844 is fixed upstream

Use gh pr edit for reviewers now that cli/cli#4844 is fixed upstream (#…

Navigation Menu

Repository navigation

`gh pr edit --add-reviewer` Don't acquire organizational teams if it's not necessary #4844

Describe the feature or problem you’d like to solve

Proposed solution

Additional context

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	union := githubv4.Boolean(false)
	reviewsRequestParams := githubv4.RequestReviewsInput{
	PullRequestID: id,
	Union: &union,
	UserIDs: ghIds(userIds),
	TeamIDs: ghIds(teamIds),
	}
	client := api.NewClientFromHTTP(httpClient)
	return api.UpdatePullRequestReviews(client, repo, reviewsRequestParams)

gh pr edit --add-reviewer Don't acquire organizational teams if it's not necessary #4844

Description

Describe the feature or problem you’d like to solve

Proposed solution

Additional context

Activity

mislav commented on Dec 3, 2021

wzshiming commented on Dec 22, 2021

mislav commented on Dec 22, 2021

wzshiming commented on Dec 22, 2021

wzshiming commented on Mar 9, 2022

mislav commented on Mar 9, 2022

wzshiming commented on Jun 15, 2022

22 remaining items

BagToad commented on Sep 25, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`gh pr edit --add-reviewer` Don't acquire organizational teams if it's not necessary #4844