Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array

I've instantiated my hideShowPassword element not to inherit margin values (since they aren't inherited properly in Firefox. See issue #33.). However, the margins are still being specified on the wrapper element. Here's how I instantiated the element:

$('#password').hideShowPassword(false, true, {
    wrapper: {
      inheritStyles: ['display', 'verticalAlign']
    }
});

This is a great catch. I forgot that jQuery.extend also applies to arrays.

inheritStyles extend exception #34

@raddevon

@raddevon This option is pretty gnarly as-is (we've got some open issues to streamline in the next version), but for now I think I've come up with a backwards-compatible quick-fix.

Could you give the version in the fix-inheritStyles branch a try for me to verify whether or not it resolves your issue?

@tylersticka

@tylersticka Yes, this fixes it. Thank you for the quick fix!

@raddevon

Thanks, @raddevon !

I'm gonna re-open this issue until it's merged into master, just in case any other users are having the problem before then.

Navigation Menu

Repository navigation

Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array #34

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array #34

Description

Activity

tylersticka commented on Jun 16, 2015

tylersticka commented on Jun 17, 2015

raddevon commented on Jun 17, 2015

tylersticka commented on Jun 17, 2015

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions