Repository navigation
browserify require is broken when jQuery versions mismatch #39
Description
Activity
- changed the title
[-]require using browserify is broken when jQuery versions mismatch[/-][+]browserify require is broken when jQuery versions mismatch[/+]on Sep 26, 2015 I can confirm when using an earlier version of jQuery than what's defined in this module's
package.jsonthat two jQuery libraries are bundled. I'll investigate further, I suspect ourpackage.jsonwill need to be updated.- added a commit that references this issue
on Sep 28, 2015 @jeremylevy I have a potential fix pushed to the
fix-jquery-dep-verbranch. You can try this locally by removing your currenthideshowpassworddependency, and re-installing with the following command:$ npm install --save cloudfour/hideShowPassword#fix-jquery-dep-verYou may also need to run
npm dedupe. After that, you should no longer see duplicate jQuery modules in the bundle that Browserify generates.Can you confirm whether or not this resolves the issue? If so, I'll go ahead and merge the branch and push this update to
npm.Thanks for your patience!
It works! You rock! Thanks 👍
Great! I'll go ahead and merge and bump the version...
@jeremylevy This fix is available in version
2.0.8. I just pushed an update tonpm.Thanks again!
Hello,
Just encountered a problem when requiring
hideshowpasswordusing Browserify.Given that I need to support IE8, jQuery is defined as
^1.11.3in mypackage.json.Since you have also added jQuery as dependency, and that the two versions mismatch, the
hideshowpasswordfunction will be attached to your jQuery instance, instead of mine, making it unavailable from my code.Why jQuery has been added as production dependency, given that the function is attached to
$.fn?