You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CmdShell does not escape asterisk arg value (SCM-763) #37
Consider your want to pass a password (on Windows) with asterisk: S8p3r*S3cr3t. The escaped outcome is S8p3r*S3cr3t. No change, but to pass an asterisk you need to quote the entire string otherwise the shell will expand the asterisk. Correct value would be: "S8p3r*S3cr3t"
Yes, it is. The entire process execution suffers from one serious flaw that it executes a local shell rather than providing it to the system directory. The shell will do its own replacement which hasn't been espaced by this implementation.
Activity
belingueres commentedon Feb 5, 2019
@michael-o is this still an issue? I see SCM-763 is fixed now.
michael-o commentedon Feb 5, 2019
Yes, it is. The entire process execution suffers from one serious flaw that it executes a local shell rather than providing it to the system directory. The shell will do its own replacement which hasn't been espaced by this implementation.
slachiewicz commentedon Apr 14, 2025
Is it worth keeping the issue open? Any idea how this should be fixed?
michael-o commentedon Apr 16, 2025
Yes, because the shell invocation needs to be dropped altogether.
slachiewicz commentedon Apr 17, 2025
Should be fixed here or deprecated here CmdShell and fix it properly on SCM?
michael-o commentedon Apr 17, 2025
Completely here replace all shell impls with ProcessBuilder