Repository navigation
Conversation
Collaborator
|
nice
…On Fri, Oct 26, 2018 at 12:15 PM Charelle Collett ***@***.***> wrote:
Instead of the while loop waiting for a worker to become available then
assigning a task, in this structure the workers request tasks when they're
free. The original while loop constantly querying the worker queue would
cause the python interpreter to lock, delaying the workers going back to
the ready pool. So on larger tasks queues with more threads, this would be
faster :)
------------------------------
You can view, comment on, or merge this pull request online at:
#1
Commit Summary
- modified threader to be more cpu efficient
File Changes
- *M* Interlace/lib/threader.py
<https://github.com/codingo/Interlace/pull/1/files#diff-0> (67)
Patch Links:
- https://github.com/codingo/Interlace/pull/1.patch
- https://github.com/codingo/Interlace/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANU_Y6mjSXVQiSaqkvNpTAXb4P70DrWQks5uomIjgaJpZM4X7XfS>
.
|
Owner
|
Makes a lot of sense, thank-you! Going to merge on presumption of testing being done since proj isn't public yet, and will do testing of my own this evening. |
codingo
approved these changes
Oct 26, 2018
codingo
pushed a commit
that referenced
this pull request
Apr 30, 2019
Update task runner to allow multi-threading on OSX
codingo
pushed a commit
that referenced
this pull request
Apr 30, 2019
Fixed case-sensitivity on subprocess.call()
codingo
pushed a commit
that referenced
this pull request
Aug 16, 2019
Fix arguments.output bug introduced in #57
codingo
pushed a commit
that referenced
this pull request
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of the while loop waiting for a worker to become available then assigning a task, in this structure the workers request tasks when they're free. The original while loop constantly querying the worker queue would cause the python interpreter to lock, delaying the workers going back to the ready pool. So on larger tasks queues with more threads, this would be faster :)