fix: report checkpoint role availability from compaction configuration - #645

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
compozy-site	Ready	Preview	Sep 15, 2026 3:52am UTC

Walkthrough

Changes

Checkpoint role projection

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: 🔵 Low · up to 8e787

The behavior change is covered, but failures in the enabled and disabled profile-switch cases will not be individually identified as required. Add named subtests before merging.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Confidence Score: 5/5

The PR appears safe to merge; the current implementation fixes the configuration-scope mismatch and no outstanding correctness or rule-compliance issues remain.

The daemon-level compaction setting now drives read-only checkpoint availability consistently with the singleton session manager, while invocation context and explicit role overrides remain separately enforced. The previous scope and missing-list-assertion findings are fixed, the missing-script finding was withdrawn, and all three threads were manually resolved.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Role status request] --> B{Checkpoint role explicitly enabled?}
    B -->|No| C[Report disabled]
    B -->|Yes| D{Effective memory enabled?}
    D -->|Yes| E[Report enabled]
    D -->|No| F{Daemon-level compaction enabled?}
    F -->|Yes| E
    F -->|No| C
    G[Checkpoint invocation] --> H{Memory enabled or invocation is compaction?}
    H -->|Yes| I[Role applicable]
    H -->|No| J[Role not applicable]

_{Reviews (5): Last reviewed commit: "test: name profile checkpoint switch cas..." | Re-trigger Greptile}

First-review collection is complete: both reviewers covered 424277f660a977afc34201e2bece9541e25cc1e7. All review, inline and general-comment pages were read, including collapsed sections.

• CodeRabbit review 5205062505: approved, no actionable inline findings. Its configured filters excluded YAML/Markdown/MDX; coverage was the four changed Go files. The docstring-coverage warning is not applicable: repository coding-style rules default to no comments and reserve one-line comments for non-obvious reasons. The status-scope and invocation distinction now have those comments; adding docstrings to test entry points or repeating private-function names would violate that convention. No coverage threshold/configuration was changed.
• Greptile review 5205054758: three findings. Scope mismatch and missing-list-entry assertion are fixed in 8e7873a708b3f4652d065f1f3c9b0e5e0a776f1f. The missing-script finding is a false positive with the exact tracked blob linked in its thread. Summary-comment findings duplicate those three identities.
• Current-head React Doctor workflow completed successfully with REACT_DOCTOR_SKIPPED=true: no React-eligible files changed, so the scan and rendered UI evidence are not applicable. Full CI is still running. No diagnostic score is claimed.

This is the single consolidated first-review remediation round. No second review or final-head reapproval is requested or claimed. Current-head CI remains a delivery requirement: https://github.com/compozy/compozy/actions/runs/34923743948 .

Consolidated integration disposition

Squash merge: 3f93805b17a9e2a9e1e499b42bbb3d6ae9374796. Integrated main: e7e4a7e329499a56fa11b364ed453a1e9d5447f7.

The scope finding is fixed: status uses daemon-level compaction availability and effective role/memory switches while invocation gates remain intact. The roster-presence assertion and named profile-switch subtests were repaired in the owning suites. The missing-checker finding was withdrawn; the checker is tracked. All four threads are resolved. The stale change-request review was dismissed only after confirming the fix and its existing resolved acknowledgment. React Doctor is not applicable to this Go-only behavior.

All pages of general/inline reviews and review threads, including outdated and collapsed material, were collected. Existing test owners were retained. Blanket docstring quotas and invitations to change reviewer filters do not override repository conventions and were not treated as production defects. No reviewer configuration, branch protection or published main history was rewritten.

Validation: integrated-main CI — passed: 26 successful jobs, with only the PR-title job skipped because this is a main push. Heavy verification ran only in GitHub CI under the explicit user override. Authorship and verification are agent-based, not human approval.