fix: cancel unbound goals before deleting sessions - #647

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
compozy-site	Ready	Preview	Sep 15, 2026 1:12pm UTC

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 3875c91.}

No actionable comments were generated in the recent review. 🎉

Walkthrough

The change fixes empty session bindings during Goal cancellation. It adds integration coverage for idempotent cancellation and deletion of stopped sessions with retained Goal state.

Changes

Goal cancellation lifecycle

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to f3fbe

The stopped-session cancellation path preserves the required projection and validation behavior, with no actionable current-head risk identified.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule findings.

The persisted origin is used only for session-origin Goals whose checkpoint binding is empty, while moved bindings remain authoritative and catalog origins emit no projection. Integration coverage verifies cancellation idempotency, retained Goal history, successful stopped-session deletion, and preservation of neighboring sessions. Both previous threads were resolved: the QA evidence was accepted, and the missing-checker report was correctly withdrawn after confirming that the script is tracked.

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Delete stopped session] --> B[Cancel owned Goal run]
    B --> C{Run has session origin?}
    C -- No: catalog origin --> D[Cancel run without session projection]
    C -- Yes --> E{Checkpoint binding present?}
    E -- Yes --> F[Project canceled status to moved binding]
    E -- No --> G[Project canceled status to persisted origin]
    F --> H[Retain checkpoint and Goal audit history]
    G --> H
    D --> H
    H --> I[Delete origin session]
    I --> J[Preserve unrelated neighboring sessions]

_{Reviews (5): Last reviewed commit: "test: verify goal deletion with complete..." | Re-trigger Greptile}

Consolidated integration disposition

Squash merge: 6b081d46f1fdf65f297e332abd679f7a58774f1a. Integrated main: e7e4a7e329499a56fa11b364ed453a1e9d5447f7.

The missing-checker finding was a false positive: the referenced checker exists in the repository. The QA finding is addressed by real SQLite/Manager cancellation and deletion coverage plus browser bulk selection, confirmation and neighbor preservation. Both threads are resolved. Rebase changed only the placement of the impact record; range-diff preserved the four implementation commits. Cancellation uses persisted origin for projection only; clear remains null and moved bindings remain authoritative.

All pages of general/inline reviews and review threads, including outdated and collapsed material, were collected. Existing test owners were retained. Blanket docstring quotas and invitations to change reviewer filters do not override repository conventions and were not treated as production defects. No reviewer configuration, branch protection or published main history was rewritten.

Validation: integrated-main CI — passed: 26 successful jobs, with only the PR-title job skipped because this is a main push. Heavy verification ran only in GitHub CI under the explicit user override. Authorship and verification are agent-based, not human approval.

Final-head evidence: real SQLite/Manager cancellation and deletion and bulk browser screenshots. Codex inspected selection, confirmation and completion on the final main commit.