Repository navigation
Send a topic's descriptionFile as metadata.description - #146
Merged
Merged
Conversation
The Console keeps a topic's description in metadata.description and refuses the conduktor.io/description label the file used to expand to, so applying any Topic with a conduktor.io/descriptionFile label failed. Labels left empty once the file label is read are dropped. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01B464sFQc8q6VkehfkByBaX
99-not-out
marked this pull request as ready for review
October 6, 2026 12:49
achever1
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
conduktor applyreads a Topic'sconduktor.io/descriptionFilelabel into aconduktor.io/descriptionlabel. The Console now keeps a topic's description inmetadata.descriptionand refuses that label (Couldn't decode key. at 'metadata.labels.conduktor.io/description'), so any Topic usingdescriptionFilefails to apply. Found while making the VS Code extension's includes match ctl's.Changes
metadata.description, and thedescriptionFilelabel is removed as before.{}.Notes
metadata.descriptionand removeddescriptionfrom the acceptedconduktor.io/labels. ctl'sdescriptionFilesupport (add support for description from file in topic resource #52) predates that and was never updated.descriptionFilereportsCreatedwith this branch, and fails with the released CLI.make lintreports two existingunparamfindings incmd/template.goonmain; untouched here.