Repository navigation
test: Strengthen trust sidecar anchor assertion - #339
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 72.16% 72.32% +0.15%
==========================================
Files 4 4
Lines 1060 1066 +6
==========================================
+ Hits 765 771 +6
Misses 295 295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scouten-adobe
force-pushed
the
bump-c2pa-0.91.0
branch
from
September 22, 2026 02:48
eccbcab to
e814118
Compare
scouten-adobe
changed the title
Keep the standalone fixture path and assert that the normalized trust anchor content contains a certificate, rather than only checking that at least one anchor was loaded. Co-authored-by: Copilot App <[email protected]>
scouten-adobe
force-pushed
the
bump-c2pa-0.91.0
branch
from
September 22, 2026 03:46
e814118 to
f316b90
Compare
scouten-adobe
added
the
backport-stable
Collaborator
|
Backport-action failed to backport this pull request in workflow run 35684870187.
❌ stable — unable to cherry-pickTried to cherry-pick commits onto Please cherry-pick the changes locally and resolve any conflicts: git fetch origin stable
git worktree add -d .worktree/backport-339-to-stable origin/stable
cd .worktree/backport-339-to-stable
git switch --create backport-339-to-stable
git cherry-pick -x f8778d649d56d43331adcdca2c77f0f779d0bc53 |
This was referenced Sep 22, 2026
scouten-adobe
added a commit
that referenced
this pull request
Sep 22, 2026
* test: Backport trust sidecar fixture path fix Backports the stable-compatible part of #339: the test fixture now uses the standalone repository path instead of the old workspace path. The stronger trust.anchors assertion from main depends on c2pa 0.91+, so stable keeps the existing trust_anchors assertion until the release-line dependency bump lands. (cherry picked from commit f316b90) Co-authored-by: Copilot App <[email protected]> * ci: Backport stable CI parity updates Backport the current main Tier 1A workflow shape and PR title validation to stable so release-line PRs run the same format, clippy, docs, lockfile, WASI, audit, and cross-platform unit checks as main. Add Cargo.lock to stable so the new locked-build check has a committed lockfile to validate. Co-authored-by: Copilot App <[email protected]> * ci: Make stable WASI checks pass Backport the target-conditional c2pa dependency split from main so stable's new WASI job uses rust_native_crypto instead of the OpenSSL backend. Also keep the stable-compatible trust fixture path fix in this CI prerequisite PR and skip the atomic write replacement unit test on WASI, where std::process::id is unsupported. Co-authored-by: Copilot App <[email protected]> --------- Co-authored-by: Copilot App <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the non-version part of the earlier stable work onto
mainfirst.This keeps
mainon its current c2pa-rsmaindependency (0.92.0-devinCargo.lock) and does not pinc2pato 0.91.0 here. The stable-only c2pa 0.91.0 pin can be handled by a backport/follow-up against the release line.Change included here:
trust.anchorsentry contains certificate material, not merely that an anchor entry exists.Validation:
cargo test --bins --lockedCo-authored-by: Copilot App [email protected]