fix(bridge): disable swap-and-bridge on the Hooks tab by tenderdeve · Pull Request #7696 · cowprotocol/cowswap

tenderdeve · 2026-06-22T13:56:46Z

Summary

Hooks orders are partially-fillable (PF), but bridge orders do not support partial fills. When a hook order is partially filled and the bridging step kicks in for the remaining amount, the order can get stuck in the 'Bridging' state indefinitely.

This PR restricts the bridging feature to the Swap route only. BridgingEnabledUpdater previously enabled bridging on both Routes.SWAP and Routes.HOOKS; the Hooks route is now excluded.

The Safe-widget feature flag (isBridgingInSafeWidgetEnabled), the disableCrossChainSwap widget param, and bridge-provider availability checks continue to apply on the Swap route.

To Test

Hooks tab — bridging disabled
- Navigate to /swap/hooks
- Bridge / cross-chain destination UI is not shown
- Placing a hooks order behaves as a regular swap order (no bridge entry points)
Swap tab — bridging unchanged
- Navigate to /swap
- Bridge / cross-chain destination UI is shown when supported chains are configured
- disableCrossChainSwap=true widget param still hides bridging
- Inside Safe app widget without isBridgingInSafeWidgetEnabled flag, bridging remains hidden
Limit / Yield / other routes
- Bridging stays disabled (unchanged)

Background

The fix is in apps/cowswap-frontend/src/modules/bridge/updaters/BridgingEnabledUpdater.ts, the sole producer of the global isBridgingEnabledAtom. Consumers of useIsBridgingEnabled (routes availability, supported tokens, swap-and-bridge UI) propagate the disabled state automatically.

A unit test BridgingEnabledUpdater.test.tsx covers:

Swap route → enabled
Hooks route → disabled (regression test for this issue)
Other routes → disabled
disableCrossChainSwap widget param respected
Bridge providers required
Safe-widget gating still applied

A code comment was added to explain why Hooks is excluded so the constraint isn't dropped by future refactors.

Summary by CodeRabbit

Changes
- Cross-chain bridging is now available only on the Swap tab; it’s disabled on the Hooks tab to avoid order-related issues.
- When bridging is active, the cross-chain URL parameter fallback now applies only for Swap, not other routes.
- Bridging remains gated by widget configuration (e.g., cross-chain disable setting), Safe widget context, feature flag, and bridge provider availability.
Tests
- Added coverage to verify bridging enablement/disablement across routes and widget/Safe/provided-bridge scenarios.

Hooks orders are partially-fillable (PF), but bridge orders do not support partial fills. When a hook order is partially filled and the remaining bridging step is triggered, the order can get stuck in the 'Bridging' state indefinitely. Restrict the bridging feature to the Swap route only. The Safe-widget flag, `disableCrossChainSwap` widget param, and bridge-provider availability checks continue to apply. Closes cowprotocol#7490

vercel · 2026-06-22T13:56:51Z

@tenderdeve is attempting to deploy a commit to the cow-dev Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2026-06-22T13:57:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1178483c-2e6a-447b-8f0c-709a43bff719

📥 Commits

Reviewing files that changed from the base of the PR and between 1ff4467 and 0e6ba18.

📒 Files selected for processing (1)

apps/cowswap-frontend/src/modules/trade/hooks/useGetTradeUrlParams.ts

Walkthrough

BridgingEnabledUpdater is updated to enable cross-chain bridging exclusively on the SWAP route, removing prior HOOKS route inclusion with explanatory comments. A separate update to useGetTradeUrlParams enforces Swap-only URL parameter fallback. A new test file covers all gating conditions: route, disableCrossChainSwap, Safe widget context, feature flag, and bridge provider presence.

Changes

Restrict bridging to Swap route

Layer / File(s)	Summary
Swap-only bridging logic in updater `apps/cowswap-frontend/src/modules/bridge/updaters/BridgingEnabledUpdater.ts`	`shouldEnableBridging` now checks `isSwapRoute` only instead of `isSwapRoute \|\| isHooksRoute`. Comments explain that Hooks is excluded due to partial-fill/order-stuck behavior. All other gates (`disableCrossChainSwap`, `shouldEnableInWidgetSafe`, `hasBridgeProviders`) are unchanged.
Enforce Swap-only URL parameter fallback `apps/cowswap-frontend/src/modules/trade/hooks/useGetTradeUrlParams.ts`	Updated to restrict bridging-mode URL parameter fallback to the Swap tab only, changing the condition from "Swap or Hooks" to "Swap only". Cross-chain references are dropped when navigating to Hooks or other routes, returning default widget parameters instead.
Test coverage for updated gating conditions `apps/cowswap-frontend/src/modules/bridge/updaters/BridgingEnabledUpdater.test.tsx`	New Jest/RTL suite mocks six hook dependencies and asserts `setIsBridgingEnabled` is called with `true` only on `SWAP`, and `false` on `HOOKS`, `LIMIT_ORDERS`, when `disableCrossChainSwap` is set, when no bridge providers exist, or inside a Safe widget without the feature flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

alfetopito
elena-zh
kernelwhisperer

Poem

🐰 Hippity-hop, the Hooks tab's sealed tight,
No bridging for orders that partial-fill at night!
The Swap page alone gets the cross-chain delight,
A flag and a Safe check keep the conditions right.
One small boolean, one big bug set to flight! 🌉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main change: disabling the swap-and-bridge feature on the Hooks tab to resolve the partial-fill stuck order issue.
Description check	✅ Passed	The description comprehensively covers all required sections: issue reference, clear explanation of the problem and solution, detailed testing steps with checkboxes, and background context. All template sections are properly filled.
Linked Issues check	✅ Passed	The PR fully addresses issue `#7490` by restricting bridging to the Swap route only, with comprehensive unit tests covering all scenarios mentioned in the issue and testing instructions validating the fix.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to disabling bridging on the Hooks tab: modifications to BridgingEnabledUpdater, useGetTradeUrlParams for proper URL state handling, and comprehensive test coverage. No out-of-scope changes detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-06-22T14:30:26Z

Cloudflare Pages preview mirror

Preview branch URL: https://github.com/cowprotocol/cowswap/tree/cf-preview/pr-7696
Mirror PR: #7698
Cloudflare Pages preview links will be posted on the mirror PR by the Cloudflare Pages GitHub integration once builds complete.

Source fork branch: tenderdeve/cowswap:fix/7490-disable-bridge-on-hooks-tab
Approval target SHA: 3bf8233dcd28
Last mirrored SHA: d4aad14e9623
Last comment update: @fairlighteth at 2026-06-26T17:09:12.022Z

Sync Cloudflare preview to approval target commit

elena-zh

Hey @tenderdeve , thank you, it works fine.
However, there is 1 nitpick: it would be nice to reset URL parameters to deafult one and remove a cross-chain swap reference from there when navigating from Swap to the Hooks tab.

Pls, compare it with navigation to limit orders page.

@elena-zh

`useGetTradeUrlParams` only kept the cross-chain output token when the target tab was Swap or Hooks. Since bridging is now disabled on the Hooks tab, navigating from a bridging Swap to Hooks would carry over the destination-chain token in the URL even though the Hooks form cannot use it. Restrict the "keep current trade context" branch to Swap only, so any non-Swap navigation (Hooks included) falls back to default assets on the current chain. Addresses @elena-zh's review on cowprotocol#7696.

fairlighteth

✅ AI Review (Codex GPT-5, worked 2m): no new findings

Review completed. I found no new non-duplicate comments worth posting.

Related context checked

Current head: d4aad14e96.
BridgingEnabledUpdater.ts:29: Hooks is excluded from bridge-enabled routes; Swap, Safe-widget, widget param, and provider gates remain covered by the same predicate.
useGetTradeUrlParams.ts:25: prior feedback is addressed; cross-chain URL state is dropped when leaving Swap, including Hooks.
Existing review context: the main behavior was manually confirmed, then approved after the URL-reset fix.
CI: BridgingEnabledUpdater.test.tsx passed; Test/Lint/Typecheck/Agent Harness passed. Cypress failed because INTEGRATION_TEST_PRIVATE_KEY is missing, so I did not treat it as PR-specific evidence.

Generated using the pr-review skill from the CoW Protocol skills repo.

fairlighteth · 2026-06-23T20:46:41Z

tenderdeve · 2026-06-24T13:48:13Z

@elena-zh updated in d4aad14 — useGetTradeUrlParams now drops the cross-chain output token whenever the user navigates from a bridging Swap to anywhere except Swap (Hooks included), so the URL is reset to default assets on the source chain.

elena-zh assigned tenderdeve Jun 22, 2026

elena-zh added the trigger-preview Add to a fork PR to trigger CF-pages preview. See https://github.com/cowprotocol/cowswap/pull/7615 label Jun 22, 2026

github-actions Bot mentioned this pull request Jun 22, 2026

preview: mirror fork PR #7696 #7698

Closed

github-actions Bot removed the trigger-preview Add to a fork PR to trigger CF-pages preview. See https://github.com/cowprotocol/cowswap/pull/7615 label Jun 22, 2026

vercel Bot temporarily deployed to Preview – storybook June 22, 2026 14:31 Inactive

vercel Bot temporarily deployed to Preview – widget-configurator June 22, 2026 14:31 Inactive

vercel Bot temporarily deployed to Preview – cowfi June 22, 2026 14:33 Inactive

Merge branch 'develop' into fix/7490-disable-bridge-on-hooks-tab

466d78b

vercel Bot temporarily deployed to Preview – storybook June 23, 2026 10:06 Inactive

vercel Bot temporarily deployed to Preview – widget-configurator June 23, 2026 10:06 Inactive

vercel Bot temporarily deployed to Preview – cowfi June 23, 2026 10:07 Inactive

elena-zh requested a review from a team June 23, 2026 10:43

elena-zh reviewed Jun 23, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview – storybook June 23, 2026 11:27 Inactive

vercel Bot temporarily deployed to Preview – widget-configurator June 23, 2026 11:27 Inactive

vercel Bot temporarily deployed to Preview – cowfi June 23, 2026 11:28 Inactive

elena-zh approved these changes Jun 23, 2026

View reviewed changes

fairlighteth reviewed Jun 23, 2026

View reviewed changes

Merge branch 'develop' into fix/7490-disable-bridge-on-hooks-tab

0e6ba18

fairlighteth requested review from a team and fairlighteth June 23, 2026 20:48

fairlighteth approved these changes Jun 23, 2026

View reviewed changes

Merge branch 'develop' into fix/7490-disable-bridge-on-hooks-tab

30fbd11

Merge branch 'develop' into fix/7490-disable-bridge-on-hooks-tab

3bf8233

fairlighteth enabled auto-merge (squash) June 26, 2026 17:09

fairlighteth merged commit 97cf3b5 into cowprotocol:develop Jun 26, 2026
12 of 18 checks passed

github-actions Bot locked and limited conversation to collaborators Jun 26, 2026

Navigation Menu

Repository navigation

fix(bridge): disable swap-and-bridge on the Hooks tab - #7696

fix(bridge): disable swap-and-bridge on the Hooks tab#7696
fairlighteth merged 6 commits into
cowprotocol:developfrom
tenderdeve:fix/7490-disable-bridge-on-hooks-tab

tenderdeve commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jun 22, 2026

Uh oh!

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

elena-zh left a comment

Uh oh!

fairlighteth left a comment

Uh oh!

fairlighteth commented Jun 23, 2026

Uh oh!

tenderdeve commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tenderdeve commented Jun 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

To Test

Background

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jun 22, 2026

Uh oh!

coderabbitai Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elena-zh left a comment

Choose a reason for hiding this comment

Uh oh!

fairlighteth left a comment

Choose a reason for hiding this comment

Uh oh!

fairlighteth commented Jun 23, 2026

Uh oh!

tenderdeve commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tenderdeve commented Jun 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading