Skip to content

packages: a chart whose suites all scope templates: stays green when a template stops rendering #4057

Closed

Description

A chart can have a full helm-unittest suite, pass it, and still ship a template that does not render.

A suite only renders the templates it names under templates:. Scope every suite in a chart that way and a template outside all of those lists never renders during the run, so breaking it changes nothing the suite sees. The summary line looks the same either way.

Same probe on two charts, a required call on a value nothing sets. packages/apps/bucket stays green at 7 of 7, because its single suite scopes to one hooks template. packages/apps/clickhouse gives 8 failed and 8 errored, because one assert among its five suites has no templates: key and renders the whole chart.

Discipline works against you here. The more carefully templates: is set on every suite, the smaller the chance a broken template gets caught by accident. Sixteen charts under packages/apps carry suites, each covered only as well as its least scoped assert.

"Covered by tests" and "renders" are separate claims, and nothing checks the second. A render sweep across all charts, outside the unit suites, would catch it. There is a change open now that adds one, and that is where these numbers came from.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/testingIssues or PRs related to testing (e2e, bats, unit tests)
    on Sep 3, 2026
  2. added
    triage/acceptedIndicates an issue is ready to be actively worked on
    priority/backlogGeneral backlog priority. Lower than priority/important-longterm
    and removed
    triage/needs-triageIndicates an issue needs triage by a maintainer
    on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/testingIssues or PRs related to testing (e2e, bats, unit tests)kind/bugCategorizes issue or PR as related to a bugpriority/backlogGeneral backlog priority. Lower than priority/important-longtermtriage/acceptedIndicates an issue is ready to be actively worked on

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions