Skip to content

build: image-packages publishes the packages artifact even with PUSH=0 #4656

Closed

Description

make image-packages in packages/core/installer/Makefile runs flux push artifact oci://$(REGISTRY)/cozystack-packages:$(IMAGE_TAG) without reading PUSH, so a local build with PUSH=0 still publishes the packages artifact. Every image target and the talos copies honour PUSH (#4551, #4654), and the installer's own helm push already reads it, so this target is the one left. A plain if around the push isn't enough: the next lines read the digest back from images/cozystack-packages.log and stamp it, so the unpushed case needs its own path, either skipping the digest stamp or stamping from a local build. Fix shape: gate the push on PUSH=1, handle the digest step for PUSH=0, and add a dry-run test that PUSH=0 emits no flux push.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug
    area/buildIssues or PRs related to image build infrastructure, multi-arch support
    on Oct 1, 2026
  2. added a commit that references this issue on Oct 5, 2026
    9c025fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area/buildIssues or PRs related to image build infrastructure, multi-arch supportkind/bugCategorizes issue or PR as related to a bugtriage/acceptedIndicates an issue is ready to be actively worked on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions