Three small items left over from the dependency rollup in #4869. None of them breaks anything today.
The token proxy sign-in path has no test for its error branch. When a session cannot be encoded, for example because a large token goes past the securecookie maximum length, sign-in now renders the login form with "Could not store the session" instead of setting an empty cookie. sessionCookie itself is covered, but the branch lives inside the handler closure in main(), so nothing exercises it over HTTP. Moving the sign-in handler out of main() would let a test hit it with an httptest request.
The kubeovn-webhook module ends up with go-openapi/swag on mixed versions after go mod tidy: the root module and most submodules are on v0.27.1, while conv, jsonutils and pools are on v0.29.2. It builds and its tests pass, but the swag submodules are meant to move together. Pinning them to one version would keep that consistent.
create-github-app-token v3 dropped its own proxy handling. On a runner that sets HTTP_PROXY or HTTPS_PROXY, the step also needs NODE_USE_ENV_PROXY=1, or the action does not use the proxy. No workflow sets proxy variables today, so this only matters if a runner pool ever sits behind a proxy.
Three small items left over from the dependency rollup in #4869. None of them breaks anything today.
The token proxy sign-in path has no test for its error branch. When a session cannot be encoded, for example because a large token goes past the securecookie maximum length, sign-in now renders the login form with "Could not store the session" instead of setting an empty cookie.
sessionCookieitself is covered, but the branch lives inside the handler closure inmain(), so nothing exercises it over HTTP. Moving the sign-in handler out ofmain()would let a test hit it with anhttptestrequest.The kubeovn-webhook module ends up with go-openapi/swag on mixed versions after
go mod tidy: the root module and most submodules are on v0.27.1, whileconv,jsonutilsandpoolsare on v0.29.2. It builds and its tests pass, but the swag submodules are meant to move together. Pinning them to one version would keep that consistent.create-github-app-token v3 dropped its own proxy handling. On a runner that sets
HTTP_PROXYorHTTPS_PROXY, the step also needsNODE_USE_ENV_PROXY=1, or the action does not use the proxy. No workflow sets proxy variables today, so this only matters if a runner pool ever sits behind a proxy.