Repository navigation
Introduce replicas options - #104
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
requested review from
George Gaál (gecube) and
Marian Koreniuk (themoriarti)
April 26, 2024 08:21
| haproxy: | ||
| replicas: 2 | ||
| nginx: | ||
| replicas: 3 |
Collaborator
There was a problem hiding this comment.
Why do you need three replicas? two replicas are enough for minimum fault tolerance.
Member
Author
There was a problem hiding this comment.
fixed, thank you
| @@ -1,2 +1,3 @@ | |||
| replicas: 3 | |||
Collaborator
There was a problem hiding this comment.
Why three replicas? 2 is enough for redis master-slave
Member
Author
There was a problem hiding this comment.
fixed, thank you
Andrei Kvapil (kvaps)
force-pushed
the
replicas
branch
from
April 26, 2024 13:11
32b144b to
3341812
Compare
Signed-off-by: Andrei Kvapil <[email protected]>
Andrei Kvapil (kvaps)
force-pushed
the
replicas
branch
from
April 26, 2024 13:19
3341812 to
7cd7de7
Compare
Marian Koreniuk (themoriarti)
approved these changes
Apr 26, 2024
Marian Koreniuk (themoriarti)
left a comment
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Practically everything is fine, I did not look into the VPN replicas, but we will fix them in the next PR #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
versions_mapgenerator script