Revert [api] Fix representation of dynamic list kinds (fixes namespace deletion regression from #1630) by kvaps · Pull Request #1677 · cozystack/cozystack

Andrei Kvapil (kvaps) · 2025-12-01T19:05:00Z

Problem

This PR reverts the changes introduced in #1630 that caused a regression affecting namespace deletion and upgrades from previous versions, particularly when running migration 20.

Symptoms

Users are experiencing issues with namespace deletion and upgrades. The namespace controller reports:

NamespaceDeletionContentFailure: True
ContentDeletionFailed: Failed to delete all resource types, 25 remaining: 
content is not a list: []unstructured.Unstructured

The error indicates that Kubernetes API server expects a proper list type, but receives []unstructured.Unstructured instead, which breaks namespace finalization.

Root Cause

The changes in #1630 modified how dynamic list kinds are represented, switching from unstructured.UnstructuredList to typed ApplicationList. While this was intended to fix kind representation issues, it introduced a compatibility problem:

The namespace deletion controller expects resources to implement the standard Kubernetes list interface
The typed lists may not be properly recognized during namespace finalization
This breaks upgrades from previous versions where resources were stored as unstructured

Solution

This PR reverts the problematic changes to restore compatibility with namespace deletion and upgrade scenarios. We are planning a more comprehensive fix that will address both the original kind representation issue and namespace deletion compatibility.

Related Issues

Fixes namespace deletion failures
Fixes upgrade issues from previous versions (migration 20)
Reverts regression introduced in [api] Fix representation of dynamic list kinds #1630

Next Steps

A more comprehensive fix is being prepared that will:

Properly handle kind representation for dynamic types
Ensure compatibility with namespace deletion controller
Support upgrades from previous versions

Summary by CodeRabbit

Release Notes

Bug Fixes
- Improved the internal structure of list API responses to ensure consistent handling and proper formatting across endpoints.
Tests
- Updated end-to-end API validation tests to refine list response checks.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-01T19:05:13Z

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Removes top-level list-kind validations from OpenAPI test and updates Application list construction in the registry to use UnstructuredList container type instead of plain Unstructured, aligning with proper Kubernetes list representation conventions.

Changes

Cohort / File(s)	Summary
Test validation removal `hack/e2e-test-openapi.bats`	Removes top-level list-kind checks for TenantList and IngressList endpoints; retains per-item kind validations for individual Tenant and Ingress objects.
Registry list handling `pkg/registry/apps/application/rest.go`	Updates List and NewList methods to use `unstructured.UnstructuredList` container instead of plain `Unstructured`; items are now assigned via the Items field and list kind is set via GroupVersion.WithKind.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify UnstructuredList initialization correctly replaces prior Unstructured approach for list responses
Confirm test removals align with the code structure change to use proper list kinds
Check that Items field assignment properly populates list items in the new container

Possibly related PRs

[api] Fix representation of dynamic list kinds #1630: Modifies list representation for dynamic resources, switching to unstructured.UnstructuredList and Items field population for correct list kind handling.

Suggested labels

size:L

Suggested reviewers

nbykov0

Poem

🐰 With UnstructuredList we now align,
No more flat objects out of line,
List kinds shine bright, per-item too,
Kubernetes conventions shining through! ✨

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d1fb4c and 0b27f63.

📒 Files selected for processing (2)

hack/e2e-test-openapi.bats (0 hunks)
pkg/registry/apps/application/rest.go (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-12-01T19:05:33Z

Summary of Changes

Hello Andrei Kvapil (@kvaps), I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses critical regressions in Kubernetes namespace deletion and upgrade processes by reverting a previous change that incorrectly modified the API representation of dynamic list kinds. Concurrently, it introduces a new feature for the postgres application, providing a robust system for managing and dynamically selecting PostgreSQL image versions.

Highlights

Reverts API Representation Change: This pull request undoes the modifications introduced in [api] Fix representation of dynamic list kinds #1630, which altered how dynamic list kinds were represented in the API, specifically by switching from unstructured.UnstructuredList to typed lists.
Fixes Namespace Deletion Regression: The revert resolves critical issues where namespace deletion failed because the Kubernetes API server expected a standard list type but was receiving []unstructured.Unstructured.
Addresses Upgrade Compatibility Issues: It corrects problems encountered during upgrades from previous versions, particularly migration 20, where resources stored as unstructured types were not properly recognized, leading to failures.
Introduces PostgreSQL Version Management: Beyond the revert, this PR adds new functionality to the postgres application, enabling dynamic selection and validation of PostgreSQL image versions through a new versioning mechanism.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	Gemini (@gemini-code-assist)	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request reverts a change that caused a regression in namespace deletion, by changing the representation of dynamic list kinds back to using unstructured.UnstructuredList. The revert in pkg/registry/apps/application/rest.go looks correct and addresses the issue described.

However, this PR also introduces a new feature for managing PostgreSQL versions, which includes a script to automatically update versions, and changes to Helm charts and CRD definitions. It's generally better to keep pull requests focused on a single concern (e.g., a revert or a new feature) to make them easier to review and track.

I've added a few comments on the new version management script regarding its robustness and maintainability, and a minor documentation suggestion.

Signed-off-by: Andrei Kvapil <[email protected]>

…st GVK This commit refactors the apiserver REST handlers to use typed objects (appsv1alpha1.Application) instead of unstructured.Unstructured, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for UnstructuredList similar to regular Unstructured objects, using GVK from the object field instead of typeToGVK. Changes: - Refactored rest.go handlers to use typed Application objects - Removed unstructured.Unstructured conversions - Fixed UnstructuredList GVK handling - Updated dependencies in go.mod/go.sum - Added e2e test for OpenAPI validation - Updated Dockerfile Signed-off-by: Andrei Kvapil <[email protected]>

…st GVK (#1679) ## What this PR does This PR refactors the apiserver REST handlers to use typed objects (`appsv1alpha1.Application`) instead of `unstructured.Unstructured`, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where `UnstructuredList` objects were using the first registered kind from `typeToGVK` instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for `UnstructuredList` similar to regular `Unstructured` objects, using GVK from the object field instead of `typeToGVK`. ### Changes - Refactored `rest.go` handlers to use typed `Application` objects - Removed `unstructured.Unstructured` conversions - Fixed `UnstructuredList` GVK handling - Updated dependencies in `go.mod`/`go.sum` - Added e2e test for OpenAPI validation - Updated Dockerfile ### Release note ```release-note [apps] Refactor apiserver to use typed objects and fix UnstructuredList GVK handling This change refactors the apiserver REST handlers to use typed Application objects instead of unstructured.Unstructured, eliminating runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were incorrectly using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This fix includes the upstream fix from kubernetes/kubernetes#135537. ```  ## Summary by CodeRabbit * **Chores** * Added a module replacement in dependency configuration to ensure reproducible builds. * **Refactor** * REST internals now use strongly-typed Application and TenantModule resources and return typed API objects with consistent metadata. * **Tests** * Strengthened end-to-end checks for resource kinds and added a create/delete namespace scenario. ✏️ Tip: You can customize this high-level summary in your review settings.

…st GVK This commit refactors the apiserver REST handlers to use typed objects (appsv1alpha1.Application) instead of unstructured.Unstructured, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for UnstructuredList similar to regular Unstructured objects, using GVK from the object field instead of typeToGVK. Changes: - Refactored rest.go handlers to use typed Application objects - Removed unstructured.Unstructured conversions - Fixed UnstructuredList GVK handling - Updated dependencies in go.mod/go.sum - Added e2e test for OpenAPI validation - Updated Dockerfile Signed-off-by: Andrei Kvapil <[email protected]> (cherry picked from commit ca29fc8)

…st GVK (#1679) ## What this PR does This PR refactors the apiserver REST handlers to use typed objects (`appsv1alpha1.Application`) instead of `unstructured.Unstructured`, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where `UnstructuredList` objects were using the first registered kind from `typeToGVK` instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for `UnstructuredList` similar to regular `Unstructured` objects, using GVK from the object field instead of `typeToGVK`. ### Changes - Refactored `rest.go` handlers to use typed `Application` objects - Removed `unstructured.Unstructured` conversions - Fixed `UnstructuredList` GVK handling - Updated dependencies in `go.mod`/`go.sum` - Added e2e test for OpenAPI validation - Updated Dockerfile ### Release note ```release-note [apps] Refactor apiserver to use typed objects and fix UnstructuredList GVK handling This change refactors the apiserver REST handlers to use typed Application objects instead of unstructured.Unstructured, eliminating runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were incorrectly using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This fix includes the upstream fix from kubernetes/kubernetes#135537. ```  ## Summary by CodeRabbit * **Chores** * Added a module replacement in dependency configuration to ensure reproducible builds. * **Refactor** * REST internals now use strongly-typed Application and TenantModule resources and return typed API objects with consistent metadata. * **Tests** * Strengthened end-to-end checks for resource kinds and added a create/delete namespace scenario. ✏️ Tip: You can customize this high-level summary in your review settings.

…st GVK This commit refactors the apiserver REST handlers to use typed objects (appsv1alpha1.Application) instead of unstructured.Unstructured, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for UnstructuredList similar to regular Unstructured objects, using GVK from the object field instead of typeToGVK. Changes: - Refactored rest.go handlers to use typed Application objects - Removed unstructured.Unstructured conversions - Fixed UnstructuredList GVK handling - Updated dependencies in go.mod/go.sum - Added e2e test for OpenAPI validation - Updated Dockerfile Signed-off-by: Andrei Kvapil <[email protected]> (cherry picked from commit ca29fc8)

…st GVK (#1679) ## What this PR does This PR refactors the apiserver REST handlers to use typed objects (`appsv1alpha1.Application`) instead of `unstructured.Unstructured`, eliminating the need for runtime conversions and simplifying the codebase. Additionally, it fixes an issue where `UnstructuredList` objects were using the first registered kind from `typeToGVK` instead of the kind from the object's field when multiple kinds are registered with the same Go type. This is a more comprehensive fix for the problem addressed in #1630, which was reverted in #1677. The fix includes the upstream fix from kubernetes/kubernetes#135537, which enables short-circuit path for `UnstructuredList` similar to regular `Unstructured` objects, using GVK from the object field instead of `typeToGVK`. ### Changes - Refactored `rest.go` handlers to use typed `Application` objects - Removed `unstructured.Unstructured` conversions - Fixed `UnstructuredList` GVK handling - Updated dependencies in `go.mod`/`go.sum` - Added e2e test for OpenAPI validation - Updated Dockerfile ### Release note ```release-note [apps] Refactor apiserver to use typed objects and fix UnstructuredList GVK handling This change refactors the apiserver REST handlers to use typed Application objects instead of unstructured.Unstructured, eliminating runtime conversions and simplifying the codebase. Additionally, it fixes an issue where UnstructuredList objects were incorrectly using the first registered kind from typeToGVK instead of the kind from the object's field when multiple kinds are registered with the same Go type. This fix includes the upstream fix from kubernetes/kubernetes#135537. ```  ## Summary by CodeRabbit * **Chores** * Added a module replacement in dependency configuration to ensure reproducible builds. * **Refactor** * REST internals now use strongly-typed Application and TenantModule resources and return typed API objects with consistent metadata. * **Tests** * Strengthened end-to-end checks for resource kinds and added a create/delete namespace scenario. ✏️ Tip: You can customize this high-level summary in your review settings.

Andrei Kvapil (kvaps) requested review from Timofei Larkin (lllamnyp) and Nikita (nbykov0) as code owners December 1, 2025 19:05

dosubot Bot added the size/L This PR changes 100-499 lines, ignoring generated files label Dec 1, 2025

dosubot Bot added the kind/bug Categorizes issue or PR as related to a bug label Dec 1, 2025

gemini-code-assist Bot reviewed Dec 1, 2025

View reviewed changes

Comment thread packages/apps/postgres/hack/update-versions.sh Outdated

Comment thread packages/apps/postgres/README.md Outdated

Comment thread packages/apps/postgres/hack/update-versions.sh Outdated

Revert [api] Fix representation of dynamic list kinds

0b27f63

Signed-off-by: Andrei Kvapil <[email protected]>

Andrei Kvapil (kvaps) force-pushed the fix-namespace-removal branch from 975e840 to 0b27f63 Compare December 1, 2025 19:07

dosubot Bot added size/S This PR changes 10-29 lines, ignoring generated files and removed size/L This PR changes 100-499 lines, ignoring generated files labels Dec 1, 2025

Andrei Kvapil (kvaps) merged commit 8bc62d4 into cozystack:main Dec 1, 2025
4 of 5 checks passed

Andrei Kvapil (kvaps) mentioned this pull request Dec 1, 2025

[apps] Refactor apiserver to use typed objects and fix UnstructuredList GVK #1679

Merged

Navigation Menu

Repository navigation

Revert [api] Fix representation of dynamic list kinds (fixes namespace deletion regression from #1630) - #1677

Revert [api] Fix representation of dynamic list kinds (fixes namespace deletion regression from #1630)#1677
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
kvaps:fix-namespace-removal

Andrei Kvapil (kvaps) commented Dec 1, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 1, 2025 •

edited

Loading

Review failed

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist Bot commented Dec 1, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Andrei Kvapil (kvaps) commented Dec 1, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Symptoms

Root Cause

Solution

Related Issues

Next Steps

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

gemini-code-assist Bot commented Dec 1, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Andrei Kvapil (kvaps) commented Dec 1, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 1, 2025 •

edited

Loading