Repository navigation
Airgapped install support - #175
Nikita (nbykov0) wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Overall, you can split this PR into three parts:
First part should provide automation for creating structure of the used images for every package by calling:
make update
The second one should provide unified makefile target to build all the images from images/ directory and output <image>.json and <image>.tag files:
make image
so every image can be builded separately:
make image-<image>
It should always output metadata and tag files with same name as image
I can help you with writing this target.
In the third it should substitute builded image metadata and tag into helm chart, so the charts should be modified or override the named template to putting correct image infromaton from these files:
This is a huge work :)
|
|
||
|
|
||
| function with_helm() { | ||
| helm template . | awk '/^[ \t"-]*image["]*: [a-zA-Z0-9/:@"\.-]+$/{print $NF}' | sed 's/"//g' | \ |
There was a problem hiding this comment.
This wont work, because we have to replace all the images with ours in the helm chart, the output of helm template . will always return our values. Try parsing upstream helm chart instead
|
I think I'll leave the PR as a place for duscussion, and then make separate ones with actual changes. |
|
Next steps:
|
|
Hello, Nikita (@nbykov0)! |
Hi Sergio (@RaSerge)! Yeah, I also dislike how it goes. |
|
My ideas:
Yesterday i found this helm plugin (it extracts images from charts).
|
|
no need to rewrite image names. It could be achieved simpler by
|
|
|
Something like this |
There is one more way by Talos itself, see |
Well, it would work for sure, but to me it seems more like a workaround. In case of a local cache I can almost feel all the concerns coming from security etc., who will notice images from public registries in private clusters :) And overriding image names on the fly might break image signing and all that. However, a pull-through/local cache is a needed feature for sure. |
|
This PR has had no activity for 60 days and was marked |
|
Closed because no activity followed the |
packages/system/capi-operatormake updatemake imageAndrei Kvapil (@kvaps) please check if I'm moving in a right direction