Skip to content

[dashboard] Fix filtering on Pods tab for Service - #1909

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix/pods-for-service
Jan 26, 2026
Merged

[dashboard] Fix filtering on Pods tab for Service#1909
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix/pods-for-service

Conversation

@sircthulhu

@sircthulhu Kirill Ilin (sircthulhu) commented Jan 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

What this PR does

Fixes filtering pods on Pods tab of Service details page

Release note

[dashboard] Fix filtering pods on Pods tab for Service

Summary by CodeRabbit

  • Bug Fixes
    • Corrected label selector field name in pod details table configuration to ensure proper label filtering functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@dosubot dosubot Bot added size/XS This PR changes 0-9 lines, ignoring generated files kind/bug Categorizes issue or PR as related to a bug labels Jan 23, 2026
@coderabbitai

coderabbitai Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

A configuration key was renamed from "labelsSelectorFull" to "labelSelectorFull" in the pod details table factory within the dashboard controller, correcting the field name while preserving all other table configuration.

Changes

Cohort / File(s) Summary
Pod Details Table Configuration
internal/controller/dashboard/static_refactored.go		 Renamed field key from "labelsSelectorFull" to "labelSelectorFull" in the EnrichedTable factory for pod details

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A label selector, once slightly askew,
Now dances with grace in the name that's true,
One character shifted, a typo undone,
The pods now align—configuration's fun! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing filtering on the Pods tab for Services by renaming a label selector field.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kvaps Andrei Kvapil (kvaps) added the kind/backport Categorizes issue or PR as requiring a backport to the current release line label Jan 24, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2026
@kvaps
Andrei Kvapil (kvaps) merged commit e8cc831 into main Jan 26, 2026
14 checks passed
@kvaps
Andrei Kvapil (kvaps) deleted the fix/pods-for-service branch January 26, 2026 17:33
@github-actions

github-actions Bot commented Jan 26, 2026

Copy link
Copy Markdown

Successfully created backport PR for release-0.41:

@github-actions github-actions Bot mentioned this pull request Jan 26, 2026
Merged
Andrei Kvapil (kvaps) added a commit that referenced this pull request Jan 26, 2026
@kvaps
[Backport release-0.41] [dashboard] Fix filtering on Pods tab for Ser…
58e2b4c 
…vice (#1914)

# Description
Backport of #1909 to `release-0.41`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) kvaps approved these changes
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@nbykov0 Nikita (nbykov0) Awaiting requested review from nbykov0

Assignees

@sircthulhu Kirill Ilin (sircthulhu)

Labels

kind/backport Categorizes issue or PR as requiring a backport to the current release line kind/bug Categorizes issue or PR as related to a bug lgtm This PR has been approved by a maintainer size/XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sircthulhu @kvaps