Repository navigation
[Backport release-1.3] fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease - #2551
Merged
Merged
Conversation
The filer and s3 blocks in the seaweedfs HelmRelease values omitted the replicas: field, so user-supplied .Values.filer.replicas and .Values.s3.replicas were silently ignored and the upstream chart defaults took over. This also caused the WorkloadMonitor resources for filer and s3 (which read the same values) to diverge from the actual replica count and trigger spurious alerts when users set non-default values. Mirror the master/volume/db pattern and interpolate replicas: into both blocks. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]> (cherry picked from commit 400da5e)
dosubot
Bot
added
size/XS
Author
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2533 to
release-1.3.