fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease by lexfrei · Pull Request #2533 · cozystack/cozystack

Aleksei Sviridkin (lexfrei) · 2026-04-29T11:05:26Z

What this PR does

The filer and s3 blocks in the seaweedfs HelmRelease values omitted the replicas: field, so user-supplied .Values.filer.replicas and .Values.s3.replicas were silently ignored and the upstream chart defaults took over. As a second-order effect, the WorkloadMonitor resources for filer and s3 (which read the same values) diverged from the actual replica count and could trigger spurious alerts when users set non-default values.

This PR mirrors the existing master / volume / db pattern and interpolates replicas: into both blocks.

Fixes #2531

Release note

fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease so user-supplied values take effect

Summary by CodeRabbit

Release Notes

Chores
- SeaweedFS deployment configuration now supports configurable replica counts for the filer and s3 components, providing flexible cluster scaling through deployment parameters.

The filer and s3 blocks in the seaweedfs HelmRelease values omitted the replicas: field, so user-supplied .Values.filer.replicas and .Values.s3.replicas were silently ignored and the upstream chart defaults took over. This also caused the WorkloadMonitor resources for filer and s3 (which read the same values) to diverge from the actual replica count and trigger spurious alerts when users set non-default values. Mirror the master/volume/db pattern and interpolate replicas: into both blocks. Assisted-By: Claude <[email protected]> Signed-off-by: Aleksei Sviridkin <[email protected]>

gemini-code-assist · 2026-04-29T11:05:34Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where custom replica counts for the filer and s3 components were being ignored in the SeaweedFS Helm deployment. By correctly passing these values through the template, the configuration now respects user overrides and ensures that monitoring resources remain synchronized with the actual deployment state.

Highlights

Configuration Fix: Added missing replicas configuration for filer and s3 components in the SeaweedFS Helm template.
Resource Synchronization: Ensured user-defined replica counts are correctly applied to prevent divergence with WorkloadMonitor resources.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	Gemini (@gemini-code-assist)	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2026-04-29T11:05:40Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 718d1ee3-a788-4cad-8741-50642617d007

📥 Commits

Reviewing files that changed from the base of the PR and between 6e045e6 and 400da5e.

📒 Files selected for processing (1)

packages/extra/seaweedfs/templates/seaweedfs.yaml

📝 Walkthrough

Walkthrough

The SeaweedFS Helm template is updated to support configurable replica counts for the filer and s3 components via .Values.filer.replicas and .Values.s3.replicas, allowing custom deployments instead of using static default values.

Changes

Cohort / File(s)	Summary
SeaweedFS Helm Template Updates `packages/extra/seaweedfs/templates/seaweedfs.yaml`	Added replica count configuration for filer and s3 components to respect custom Helm values instead of hardcoded defaults.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two little values, now finally seen,
In the template where replicas convene,
Filer and s3, customized at last,
No more defaults holding steady and fast!
The config bug hop-hops into the past. 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding filer.replicas and s3.replicas parameters to the SeaweedFS HelmRelease template.
Linked Issues check	✅ Passed	The PR directly addresses issue `#2531` by adding the missing filer.replicas and s3.replicas fields to the HelmRelease template, allowing user-supplied values to take effect and preventing spurious alerts.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly scoped to resolving issue `#2531`; only the seaweedfs.yaml template was modified to add the two missing replica parameters with no unrelated alterations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/seaweedfs-filer-s3-replicas

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request updates the SeaweedFS template to allow configuring the number of replicas for the filer and S3 components via Helm values. I have no feedback to provide.

IvanHunters

filer.replicas and s3.replicas both have defaults in values.yaml, and the WorkloadMonitor for filer was already reading .Values.filer.replicas for alerting — so the monitor was counting against a different value than what the chart actually deployed. The fix is consistent with the db / master / volume pattern.

LGTM

github-actions · 2026-05-01T11:16:11Z

Successfully created backport PR for release-1.3:

[Backport release-1.3] fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease #2551

…licas to HelmRelease (#2551) # Description Backport of #2533 to `release-1.3`.

Aleksei Sviridkin (lexfrei) requested review from IvanHunters, Andrey Kolkov (androndo), Andrei Kvapil (kvaps), Timofei Larkin (lllamnyp), myasnikovdaniil and Kirill Ilin (sircthulhu) as code owners April 29, 2026 11:05

Aleksei Sviridkin (lexfrei) added the kind/backport Categorizes issue or PR as requiring a backport to the current release line label Apr 29, 2026

github-actions Bot added area/storage Issues or PRs related to storage (linstor, seaweedfs, bucket, velero, harbor) kind/bug Categorizes issue or PR as related to a bug labels Apr 29, 2026

dosubot Bot added the size/XS This PR changes 0-9 lines, ignoring generated files label Apr 29, 2026

dosubot Bot added the area/extra Issues or PRs related to tenant-specific modules (packages/extra/) label Apr 29, 2026

gemini-code-assist Bot reviewed Apr 29, 2026

View reviewed changes

Aleksei Sviridkin (lexfrei) self-assigned this Apr 29, 2026

IvanHunters approved these changes Apr 29, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2026

Andrei Kvapil (kvaps) merged commit 5ef1500 into main May 1, 2026
17 checks passed

Andrei Kvapil (kvaps) deleted the fix/seaweedfs-filer-s3-replicas branch May 1, 2026 11:15

github-actions Bot mentioned this pull request May 1, 2026

[Backport release-1.3] fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease #2551

Merged

myasnikovdaniil added a commit that referenced this pull request May 6, 2026

[Backport release-1.3] fix(seaweedfs): pass filer.replicas and s3.rep…

313a1ac

…licas to HelmRelease (#2551) # Description Backport of #2533 to `release-1.3`.

Navigation Menu

Repository navigation

fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease - #2533

fix(seaweedfs): pass filer.replicas and s3.replicas to HelmRelease#2533
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix/seaweedfs-filer-s3-replicas

Aleksei Sviridkin (lexfrei) commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

gemini-code-assist Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

IvanHunters left a comment

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Aleksei Sviridkin (lexfrei) commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Release note

Summary by CodeRabbit

Release Notes

Uh oh!

gemini-code-assist Bot commented Apr 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

IvanHunters left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aleksei Sviridkin (lexfrei) commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading