Skip to content

cilium: disable hostLegacyRouting - #308

Closed
Andrei Kvapil (kvaps) wants to merge 1 commit into
mainfrom
cilium-hostlegacy
Closed

cilium: disable hostLegacyRouting#308
Andrei Kvapil (kvaps) wants to merge 1 commit into
mainfrom
cilium-hostlegacy

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Aug 29, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Introduced a new configuration option, hostLegacyRouting, allowing users to control legacy routing behavior for enhanced network performance and compatibility.

@coderabbitai

coderabbitai Bot commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The change introduces a new configuration option, hostLegacyRouting, in the bpf section of the Cilium configuration within the values.yaml file. This option is set to false, disabling legacy routing for the host and providing users with more control over Cilium's network behavior.

Changes

Files Change Summary
packages/system/cilium/values.yaml Added new configuration option hostLegacyRouting: false under the bpf section.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Cilium
    participant Kubernetes

    User->>Cilium: Set hostLegacyRouting to false
    Cilium->>Kubernetes: Apply new BPF settings
    Kubernetes->>Cilium: Confirm configuration update
    Cilium->>User: Configuration updated successfully
Loading

Poem

🐰 In the meadow where I play,
A new setting brightens the day!
With hostLegacyRouting set to false,
Cilium dances, no need to pulse!
Hops of joy, let’s cheer and sing,
For better routing, oh what a thing! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed Aug 29, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5b631a6 and 7931b06.

Files selected for processing (1)
  • packages/system/cilium/values.yaml (1 hunks)
Additional comments not posted (1)
packages/system/cilium/values.yaml (1)

10-10: LGTM! Consider adding documentation for the new configuration option.

The addition of the hostLegacyRouting configuration option under the bpf section provides more granular control over the BPF settings, potentially improving network management capabilities within Cilium. Ensure to document this new option to inform users about its purpose and usage.

pull Bot pushed a commit to medampudi/cozystack that referenced this pull request May 1, 2026
@lexfrei
chore(etcd-operator): update vendored chart to v0.4.3
8734c38 
Upstream release notes: https://github.com/aenix-io/etcd-operator/releases/tag/v0.4.3

Notable changes:
- Add EtcdBackup CRD for declarative etcd snapshots (cozystack#307)
- Add EtcdBackupSchedule CRD for scheduled backups (cozystack#307)
- Expose metrics port on client service (cozystack#299)
- Replace deprecated gcr.io/kubebuilder/kube-rbac-proxy with
  quay.io/brancz/kube-rbac-proxy:v0.18.1 (cozystack#308)
- Update Kamaji example manifest

Note: Helm 3 does not install CRDs on upgrade. Existing clusters
require manual application of the new EtcdBackup and
EtcdBackupSchedule CRDs:

  kubectl apply --filename packages/system/etcd-operator/charts/etcd-operator/crds/

Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps