Repository navigation
[Backport release-1.6] fix(cluster-api): backport live migration before host eviction - #4474
Merged
Merged
Conversation
1 of 12 tasks
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: cozystack/cozystack/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Yan Bondarenko <[email protected]> (cherry picked from commit c8f4906)
Signed-off-by: Yan Bondarenko <[email protected]> (cherry picked from commit bb3a2fa)
A migration that KubeVirt never processes must not block host eviction indefinitely. Keep its submission deadline separate from active migration and fallback drain windows. Signed-off-by: Yan Bondarenko <[email protected]> (cherry picked from commit c85f350)
…uite hack/bats-no-exit-trap.bats is an exact ratchet, and the new suite installs three traps inside explicit subshells without declaring them, so make unit-tests fails on the merge commit. The header now declares the count and says why the three are not debt. Assisted-by: LLM Signed-off-by: Yan Bondarenko <[email protected]> (cherry picked from commit 0e4d6a3)
…ed API CAPK v0.1.10 pins kubevirt.io/api v1.5.0, whose VirtualMachineInstanceMigrationSpec carries only vmiName; upstream #392 sets priority against v1.9.0. The typed migration does not compile against the pinned API, which is why the patch builds it unstructured. Assisted-by: LLM Signed-off-by: Yan Bondarenko <[email protected]> (cherry picked from commit bc2ba10)
The CAPK build suite came over from main asserting that an image build under OCI_EXPORT_DIR writes an OCI archive with --push=0. That export path lives in hack/common-envs.mk on main and was never brought to this branch, where every build pushes, so the suite failed here on every run. What the suite is for still holds on this branch: the build stamps a digest-pinned ref into the .tag file that the image-ref tooling finds, it leaves the shipped components untouched, and a failed build or a missing digest keeps the previous pin. Those checks stay; the OCI parameter and the three archive checks go. Assisted-by: LLM Signed-off-by: Myasnikov Daniil <[email protected]>
myasnikovdaniil
force-pushed
the
backport-4291-to-release-1.6
branch
from
September 25, 2026 06:03
579c9d9 to
316dcef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4291 to
release-1.6.