Skip to content

[e2e] fix timeouts for capi and keycloak - #858

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-e2e-timeouts
Apr 23, 2025
Merged

[e2e] fix timeouts for capi and keycloak#858
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-e2e-timeouts

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 23, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil [email protected]

Summary by CodeRabbit

  • Chores
    • Increased timeout durations for waiting on certain Kubernetes resources to improve reliability during environment setup.

@coderabbitai

coderabbitai Bot commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The script hack/e2e.sh has been updated to increase the timeout durations for waiting on specific Kubernetes resources. The waiting period for Cluster-API provider deployments in the cozy-cluster-api namespace has been doubled from 30 seconds to 60 seconds. Likewise, the polling loop for HelmReleases in the cozy-keycloak namespace now waits up to 120 seconds instead of 60 seconds. The kubectl wait timeout for HelmReleases remains unchanged at 10 minutes. No changes were made to exported or public entity declarations.

Changes

File(s) Change Summary
hack/e2e.sh Increased timeout values for waiting on Cluster-API provider deployments and HelmReleases.

Poem

🕰️
The script now waits a little more,
For clusters and releases to open the door.
Sixty seconds, then one twenty—plenty of time,
For resources to ready, in orchestrated rhyme.
Patience is key, as the clusters align,
With every new wait, our tests will shine!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16ee0f2 and 1c53a6f.

📒 Files selected for processing (1)
  • hack/e2e.sh (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (2)
hack/e2e.sh (2)

237-238: Doubled timeouts for Cluster-API provider deployments
The polling loop and kubectl wait for deployments in the cozy-cluster-api namespace have been correctly extended from 30s to 60s, providing more headroom for providers to initialize. LGTM.

360-360: Extended polling loop for Keycloak HelmReleases
The initial polling loop for HelmReleases in cozy-keycloak has been increased from 60s to 120s as intended, matching the longer expected startup time. LGTM.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps Andrei Kvapil (kvaps) added the kind/backport Categorizes issue or PR as requiring a backport to the current release line label Apr 23, 2025
lllamnyp
Timofei Larkin (lllamnyp) approved these changes Apr 23, 2025
View reviewed changes

@lllamnyp Timofei Larkin (lllamnyp) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this will solve everything, but let's give it a shot.

@kvaps
Andrei Kvapil (kvaps) merged commit 89525de into main Apr 23, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the fix-e2e-timeouts branch April 23, 2025 12:26
@github-actions

github-actions Bot commented Apr 23, 2025

Copy link
Copy Markdown

Successfully created backport PR for release-0.30:

@github-actions github-actions Bot mentioned this pull request Apr 23, 2025
Merged
Andrei Kvapil (kvaps) added a commit that referenced this pull request Apr 23, 2025
@kvaps
[Backport release-0.30] [e2e] fix timeouts for capi and keycloak (#860)
6c8d113 
# Description
Backport of #858 to `release-0.30`.
@coderabbitai coderabbitai Bot mentioned this pull request Apr 24, 2025
Closed
@myasnikovdaniil myasnikovdaniil mentioned this pull request Apr 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) lllamnyp approved these changes
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

@NickVolynkin Nick Volynkin (NickVolynkin)

Labels

kind/backport Categorizes issue or PR as requiring a backport to the current release line

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvaps @lllamnyp @NickVolynkin