Skip to content

Fix incorrect path to include in Makefiles - #89

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
83-refactor-makefiles
Apr 17, 2024
Merged

Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
83-refactor-makefiles

Conversation

@themoriarti

@themoriarti Marian Koreniuk (themoriarti) commented Apr 17, 2024 •

Copy link
Copy Markdown
Collaborator

fix regression introduced by #86

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps Andrei Kvapil (kvaps) changed the title Сorrection of insufficient level of folders Сorrection of insufficient level of folders in Makefiles Apr 17, 2024
@kvaps Andrei Kvapil (kvaps) changed the title Сorrection of insufficient level of folders in Makefiles Fix insufficient level of folders in Makefiles Apr 17, 2024
@kvaps Andrei Kvapil (kvaps) changed the title Fix insufficient level of folders in Makefiles Fix incorrect party to include in Makefiles Apr 17, 2024
@kvaps
Andrei Kvapil (kvaps) merged commit 2e46eea into main Apr 17, 2024
@kvaps Andrei Kvapil (kvaps) changed the title Fix incorrect party to include in Makefiles Fix incorrect path to include in Makefiles Apr 17, 2024
Andrei Kvapil (kvaps) pushed a commit that referenced this pull request Apr 17, 2024
fix regression introduced by #86

Signed-off-by: Andrei Kvapil <[email protected]>
@themoriarti
Marian Koreniuk (themoriarti) deleted the 83-refactor-makefiles branch August 5, 2024 20:49
Aleksei Sviridkin (lexfrei) added a commit that referenced this pull request Mar 23, 2026
Update COSI controller/sidecar from commit c2f6e65 to v0.2.2
(f75d475) and remove two patches that have been merged upstream:

- 89-reconciliation.diff: fix reconciliation logic for existing
  and deleted objects (PR #89)
- 90-bucket-name.diff: prefix bucket names with bucket- using
  UID only (PR #90)

Both patches were contributed by kvaps and included in the
upstream v0.2.2 release (2025-12-08).

Also remove git from Dockerfile dependencies as it was only
needed for applying patches.

Assisted-By: Claude <[email protected]>
Signed-off-by: Aleksei Sviridkin <[email protected]>
Kirill Ilin (sircthulhu) added a commit that referenced this pull request Mar 26, 2026
…2261)

## What this PR does

Update COSI controller/sidecar from commit `c2f6e65` to upstream
release `v0.2.2` and remove two patches that have been merged:

- `89-reconciliation.diff` — fix reconciliation logic for existing
  and deleted objects (upstream PR #89)
- `90-bucket-name.diff` — prefix bucket names with `bucket-` using
  UID only (upstream PR #90)

Both were contributed by kvaps and included in the v0.2.2 release
(2025-12-08).

Also removes `git` from Dockerfile dependencies as it was only
needed for applying patches.

Note: `make image` needs to be run to rebuild the container image
and update `values.yaml` with the new tag/digest.

### Release note

```release-note
[objectstorage-controller] Update to v0.2.2, drop upstreamed patches
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Updated object storage controller build configuration to streamline
upstream component retrieval and image build process.
* Modified resource deletion handling so deletion flows are centralized
and consistently enforced across create/update events.
* Changed bucket naming scheme—buckets will no longer include the bucket
class name in their identifier and follow the simplified naming pattern.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants