Skip to content

d3.bin should check for null #203

Description

@mbostock

Our threshold implementations do already, which is good (via count), but we shouldn’t be passing null values in here:

d3-array/src/bin.js

Lines 80 to 82 in 6fda277

if (x0 <= x && x <= x1) {
bins[bisect(tz, x, 0, m)].push(data[i]);
}

(Undefined and NaN values already fail this test, so we’re good on those.)

Activity

  1. added a commit that references this issue on May 27, 2021
    f09b9f5
  2. added a commit that references this issue on Jun 5, 2021
    080695a
  3. added a commit that references this issue on Jun 5, 2021
    5cbc1e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions