Skip to content

[Proposal] Migrate waitForSidecar to v1.0/healthz/outbound to provide parity with dotnet SDK #897

Description

@olitomlinson

Describe the proposal

In my opinion, the dotnet SDK provides a more explicit implementation that is better isolated from accidental change.

For example, if the ordering of a dapr runtime init ever changed (accidentally or deliberately), and the dapr http port was open before all components were initialised, then this would cause a break in behaviour.

Therefore, for this reason, I propose that the Java SDK (and other SDKs) should follow the same behaviour as the dotnet SDK and wait for a successful response from v1.0/healthz/outbound rather than just waiting for the dapr http port to be open.


This is my understanding of the relationship between Dapr and the App during init

image

Activity

  1. changed the title [-][Proposal] Migrate `waitForSidecar` to `v1.0/healthz/outbound` to maintain parity with dotnet SDK[/-] [+][Proposal] Migrate `waitForSidecar` to `v1.0/healthz/outbound` to provide parity with dotnet SDK[/+] on Aug 30, 2023
  2. cicoyle commented on Sep 21, 2023

    @cicoyle
    Contributor

    /assign

  3. cicoyle commented on Jan 5, 2024

    @cicoyle
    Contributor

    once the docs PR I have open gets merged, then this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions