Skip to content

add wait for sidecar docs & update java-sdk docs to match .net more w… - #981

Merged
artursouza merged 5 commits into
dapr:masterfrom
cicoyle:docs-wait-for-sidecar
Jan 8, 2024
Merged

artursouza merged 5 commits into
dapr:masterfrom
cicoyle:docs-wait-for-sidecar

Conversation

@cicoyle

@cicoyle cicoyle commented Jan 5, 2024 •

Copy link
Copy Markdown
Contributor

Description

add wait for sidecar and shutdown docs to sdk docs page. also updated file name to match docs requirement here, stating files/folders should start w/ java-. I also added Available packages to the landing page for the java sdk docs (in line w/ dotnet landing page). I also changed the java-workflow.md to be java-workflow-howto.md since that is how dotnet had it.

image
image
image
image

Issue reference

docs for: #918

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@cicoyle
cicoyle requested review from a team as code owners January 5, 2024 17:57
@cicoyle
cicoyle requested review from a team and hhunter-ms and removed request for a team January 5, 2024 17:57
@codecov

codecov Bot commented Jan 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c312bd) 76.29% compared to head (500a4ea) 76.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #981   +/-   ##
=========================================
  Coverage     76.29%   76.29%           
  Complexity     1463     1463           
=========================================
  Files           138      138           
  Lines          4497     4497           
  Branches        524      524           
=========================================
  Hits           3431     3431           
  Misses          784      784           
  Partials        282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhunter-ms hhunter-ms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants