This looks good to me, great work @cicoyle !

@cicoyle @mukundansundar

If you haven't already, It's worth checking in with @artursouza as this class DaprClientHttp is planned to be deprecated in the next version of the SDK.

If that is still true, these changes also need porting over to DaprClientGrpc - as this issue suggests #898

@cicoyle @mukundansundar

If you haven't already, It's worth checking in with @artursouza as this class DaprClientHttp is planned to be deprecated in the next version of the SDK.

If that is still true, these changes also need porting over to DaprClientGrpc - as this issue suggests #898

Good point @olitomlinson! One issue with the gRPC waitForSidecar function is that it only waits for the channel to be ready, not for Dapr outbound to be ready. Either as done in .NET SDK as linked above or as mentioned in the Python SDK issue, we either need gRPC client to also check the HTTP healthz/outbound endpoint or create a IsOutboundReady gRPC method in dapr Runtime.

@cicoyle @mukundansundar
If you haven't already, It's worth checking in with @artursouza as this class DaprClientHttp is planned to be deprecated in the next version of the SDK.
If that is still true, these changes also need porting over to DaprClientGrpc - as this issue suggests #898

Good point @olitomlinson! One issue with the gRPC waitForSidecar function is that it only waits for the channel to be ready, not for Dapr outbound to be ready. Either as done in .NET SDK as linked above or as mentioned in the Python SDK issue, we either need gRPC client to also check the HTTP healthz/outbound endpoint or create a IsOutboundReady gRPC method in dapr Runtime.

Not that I have any say in the matter, but I think being consistent with the dotnet SDK and calling healthz/outbound is the pragmatic thing to do right now :)

Unfortunately, this works locally on my Mac, but not in CI - trying to debug

I reproduced this error locally.

The error is because the test is not passing the interceptor to an OkHTTP client. You need this in GrpcChannelFacadeTest:

    okHttpClient = new OkHttpClient.Builder().addInterceptor(mockInterceptor).build();

And then, use the custom okHttpClient:

DaprHttp daprHttp = new DaprHttp(Properties.SIDECAR_IP.get(), 3500, okHttpClient);

It might be working locally because you might have a running sidecar and makes the test pass.

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0c7828e) 76.55% compared to head (e9d07e4) 76.23%.

@@             Coverage Diff              @@
##             master     #918      +/-   ##
============================================
- Coverage     76.55%   76.23%   -0.33%     
+ Complexity     1469     1462       -7     
============================================
  Files           138      138              
  Lines          4475     4489      +14     
  Branches        527      524       -3     
============================================
- Hits           3426     3422       -4     
- Misses          763      784      +21     
+ Partials        286      283       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.