Repository navigation
add reference types from dwn-sdk-js to avoid pnpm build error - #507
Merged
Merged
Conversation
LiranCohen
requested review from
csuwildcat,
frankhinek,
mistermoe and
shamilovtim
as code owners
May 2, 2024 13:02
🦋 Changeset detectedLatest commit: facd2f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shamilovtim
previously approved these changes
May 2, 2024
LiranCohen
force-pushed
the
lirancohen/export-inferred-types
branch
from
May 2, 2024 16:34
8cc806f to
eb02b62
Compare
LiranCohen
requested review from
diehuxx,
jiyoonie9 and
thehenrytsai
as code owners
May 2, 2024 16:34
Contributor
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-02T16:54:17Z |
thehenrytsai
previously approved these changes
May 2, 2024
thehenrytsai
left a comment
thehenrytsai
left a comment
Contributor
There was a problem hiding this comment.
Consider adding an in-line comment to the type reference to explain why it is added, else it might not be easy/obvious to reverse engineer why the line is there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 90.81% 90.81%
=======================================
Files 116 116
Lines 29414 29442 +28
Branches 2156 2156
=======================================
+ Hits 26711 26739 +28
Misses 2668 2668
Partials 35 35
|
shamilovtim
approved these changes
May 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpmencounters some build errors for inferred types when there are 2 different versions of the same package in a monorepo.microsoft/TypeScript#47663 (comment)
Adding
/// <reference types="@tbd54566975/dwn-sdk-js" />at the top of files which would infer these types allows the build system to understand them, i believe while keeping this package as a devDependency.I don't think that this is the long-term solution here, but may be a temporary fix until we decide on a permanent one potentially bringing in
dwn-sdk-jsas a first class dependency ofapiand get rid of the type-wrapping we are doing inagent