Repository navigation
fix(core): make Unix pipe fd ownership explicit - #36353
Merged
Merged
Conversation
bartlomieju
pushed a commit
that referenced
this pull request
Aug 27, 2026
## Summary - keep raw Unix pipe descriptors owned by the pipe handle until ownership is transferred - make Tokio streams and listeners the sole closer after connect, accept, or listen - retain explicit cleanup for descriptor-only pipes and non-owning `AsyncFd` registrations - cover raw, listener, accepted-stream, and bound-connect ownership transitions ## Tests - `./tools/format.js` - `cargo test -p deno_core 'uv_compat::tests' --lib` - `cargo clippy -p deno_core --lib --tests --no-deps -- -D warnings` - `cargo build -p deno --bin deno`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncFdregistrationsTests
./tools/format.jscargo test -p deno_core 'uv_compat::tests' --libcargo clippy -p deno_core --lib --tests --no-deps -- -D warningscargo build -p deno --bin deno