Repository navigation
fix(IDX): Don't overwrite CDN artifacts - #5438
Merged
Merged
Conversation
nmattia
force-pushed
the
nm-immutable-upload
branch
from
June 5, 2025 14:42
0d30c09 to
7a90867
Compare
Contributor
Author
|
Seems to work! Now need to figure out why the SHA256SUMS are changing... |
basvandijk
approved these changes
Jun 5, 2025
We use `--immutable` to avoid overwriting artifacts in the CDN/S3. Unfortunately, for single-file uploads, `--immutable` does not work as expected: rclone/rclone#4921 This introduces a workaround so that we can still upload artifacts one by one -- instead of full directories -- as uploading artifacts individually allows us to produce meaningful logs.
nmattia
force-pushed
the
nm-immutable-upload
branch
from
June 10, 2025 14:18
ad50388 to
6c74997
Compare
Contributor
Author
|
This is the cause: #5487 |
nmattia
force-pushed
the
nm-immutable-upload
branch
from
June 12, 2025 23:11
dd7bae5 to
465b7dc
Compare
nmattia
enabled auto-merge
June 12, 2025 23:11
aterga
pushed a commit
that referenced
this pull request
Jun 17, 2025
We use `--immutable` to avoid overwriting artifacts in the CDN/S3. Unfortunately, for single-file uploads, `--immutable` does not work as expected: rclone/rclone#4921 This introduces a workaround so that we can still upload artifacts one by one -- instead of full directories -- as uploading artifacts individually allows us to produce meaningful logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
--immutableto avoid overwriting artifacts in the CDN/S3. Unfortunately, for single-file uploads,--immutabledoes not work as expected: rclone/rclone#4921This introduces a workaround so that we can still upload artifacts one by one -- instead of full directories -- as uploading artifacts individually allows us to produce meaningful logs.